Fix potential oob read in mca_coll_han_query_module_from_mca #10964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported as CID 1516096. Signed-off-by: Joseph Schuchart <[email protected]>
bosilca
approved these changes
Oct 21, 2022
Member
|
@devreal Please merge, and CP back to v5.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported as CID 1516096. The
mod_idmust be one less than theCOMPONENTS_COUNTupper bound.I removed the second check because I don't see how
mod_idcould be negative at that point.Signed-off-by: Joseph Schuchart [email protected]