Skip to content

Commit c06de8f

Browse files
author
Valentin Petrov
committed
PML/UCX: don't do pml_check_selected call
Current implementation of pml check protocol causes extra dmodex exchanges that may result in a significant performance degradation for some workloads (corresponds to master 36b64cb) Signed-off-by: Valentin Petrov <[email protected]>
1 parent c9ed1f7 commit c06de8f

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

ompi/mca/pml/ucx/pml_ucx.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -412,15 +412,6 @@ static ucp_ep_h mca_pml_ucx_add_proc(ompi_communicator_t *comm, int dst)
412412
{
413413
ompi_proc_t *proc0 = ompi_comm_peer_lookup(comm, 0);
414414
ompi_proc_t *proc_peer = ompi_comm_peer_lookup(comm, dst);
415-
int ret;
416-
417-
/* Note, mca_pml_base_pml_check_selected, doesn't use 3rd argument */
418-
if (OMPI_SUCCESS != (ret = mca_pml_base_pml_check_selected("ucx",
419-
&proc0,
420-
dst))) {
421-
return NULL;
422-
}
423-
424415
return mca_pml_ucx_add_proc_common(proc_peer);
425416
}
426417

@@ -429,13 +420,6 @@ int mca_pml_ucx_add_procs(struct ompi_proc_t **procs, size_t nprocs)
429420
ompi_proc_t *proc;
430421
ucp_ep_h ep;
431422
size_t i;
432-
int ret;
433-
434-
if (OMPI_SUCCESS != (ret = mca_pml_base_pml_check_selected("ucx",
435-
procs,
436-
nprocs))) {
437-
return ret;
438-
}
439423

440424
for (i = 0; i < nprocs; ++i) {
441425
proc = procs[(i + OMPI_PROC_MY_NAME->vpid) % nprocs];

0 commit comments

Comments
 (0)