mtl/ofi: Check ompi_ret in ompi_mtl_ofi_send_generic

Luke Robison · Luke Robison · commit 1e9e9b71cb07 · 2023-05-16T19:10:41.000Z
Correct issue Coverity issue CID 1515755.

Signed-off-by: Luke Robison &lt;lrbison@amazon.com&gt;
diff --git a/ompi/mca/mtl/ofi/mtl_ofi.h b/ompi/mca/mtl/ofi/mtl_ofi.h
@@ -855,11 +855,17 @@ ompi_mtl_ofi_send_generic(struct mca_mtl_base_module_t *mtl,
         if (mtl_comm->c_index_vec[dest].c_index_state == MCA_MTL_OFI_CID_NOT_EXCHANGED) {
             mtl_comm->c_index_vec[dest].c_index_state = MCA_MTL_OFI_CID_EXCHANGING;
             ompi_ret = ompi_mtl_ofi_send_excid(mtl, comm, dest, ofi_cq_data, true);
+            if (OPAL_UNLIKELY(OMPI_SUCCESS != ompi_ret)) {
+                return ompi_ret;
+            }
         }
 
         if (mtl_comm->c_index_vec[dest].c_index_state > MCA_MTL_OFI_CID_EXCHANGED) {
              while (mtl_comm->c_index_vec[dest].c_index_state > MCA_MTL_OFI_CID_EXCHANGED) {
                 ompi_ret = ompi_mtl_ofi_post_recv_excid_buffer(true, comm, dest);
+                if (OPAL_UNLIKELY(OMPI_SUCCESS != ompi_ret)) {
+                    return ompi_ret;
+                }
             }
         }
         c_index_for_tag = mtl_comm->c_index_vec[dest].c_index;

Original file line number	Diff line number	Diff line change
`@@ -855,11 +855,17 @@ ompi_mtl_ofi_send_generic(struct mca_mtl_base_module_t *mtl,`
`855`	`855`	`if (mtl_comm->c_index_vec[dest].c_index_state == MCA_MTL_OFI_CID_NOT_EXCHANGED) {`
`856`	`856`	`mtl_comm->c_index_vec[dest].c_index_state = MCA_MTL_OFI_CID_EXCHANGING;`
`857`	`857`	`ompi_ret = ompi_mtl_ofi_send_excid(mtl, comm, dest, ofi_cq_data, true);`
	`858`	`+ if (OPAL_UNLIKELY(OMPI_SUCCESS != ompi_ret)) {`
	`859`	`+ return ompi_ret;`
	`860`	`+ }`
`858`	`861`	`}`
`859`	`862`
`860`	`863`	`if (mtl_comm->c_index_vec[dest].c_index_state > MCA_MTL_OFI_CID_EXCHANGED) {`
`861`	`864`	`while (mtl_comm->c_index_vec[dest].c_index_state > MCA_MTL_OFI_CID_EXCHANGED) {`
`862`	`865`	`ompi_ret = ompi_mtl_ofi_post_recv_excid_buffer(true, comm, dest);`
	`866`	`+ if (OPAL_UNLIKELY(OMPI_SUCCESS != ompi_ret)) {`
	`867`	`+ return ompi_ret;`
	`868`	`+ }`
`863`	`869`	`}`
`864`	`870`	`}`
`865`	`871`	`c_index_for_tag = mtl_comm->c_index_vec[dest].c_index;`