Skip to content

Conversation

@MaelRB
Copy link

@MaelRB MaelRB commented Sep 17, 2025

This PR

  • Add Tracking API following OpenFeature specifications
  • Every requirement from tracking has been developed
  • No breaking change

Related Issues

Fixes 1234523

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @MaelRB, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the OpenFeature Swift SDK by integrating the Tracking API. This feature allows developers to associate user actions and application states with feature flag evaluations, which is vital for robust experimentation and collecting telemetry. The changes introduce new core components for tracking, seamlessly integrate them into existing client and provider interfaces without breaking changes, and ensure that evaluation contexts are correctly merged for comprehensive data capture during tracking events.

Highlights

  • Tracking API Implementation: The OpenFeature Swift SDK now includes a comprehensive Tracking API, fully adhering to the OpenFeature specifications for associating user actions with feature flag evaluations.
  • New Protocols and Structures: Introduced Tracking and TrackingEventDetails protocols, along with the ImmutableTrackingEventDetails struct, to define and manage tracking event data.
  • Client and Provider Integration: The Client protocol now conforms to Tracking, and OpenFeatureClient has been extended with track methods. The FeatureProvider protocol includes a new track method with a default no-op implementation for extensibility.
  • Evaluation Context Merging: Enhanced OpenFeatureClient with logic to merge API-level and invocation-level evaluation contexts when reporting track events, ensuring comprehensive context capture.
  • Documentation and Tests: The README.md has been updated to reflect the availability of the Tracking API with code examples. New unit tests have been added to validate the tracking functionality, context merging, and the ImmutableTrackingEventDetails struct.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@MaelRB MaelRB changed the title Add Tracking API feat: add Tracking API Sep 17, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Tracking API, aligning the Swift SDK with the OpenFeature specification. The changes include new protocols (Tracking, TrackingEventDetails), concrete implementations (ImmutableTrackingEventDetails), and updates to the Client and FeatureProvider to support tracking events. The implementation is well-structured, with good separation of concerns and comprehensive test coverage for the new functionality. I've identified a potential issue in the context merging logic and a couple of areas for minor code simplification. Overall, this is a great addition to the SDK.

@beeme1mr
Copy link
Member

Hey @MaelRB, thanks for the PR! Could you please sign off on your commits? It's a requirement from the CNCF because it signifies that you're willing and able to donate this code.

Instructions for signing previous commits can be found here. Thanks!

Signed-off-by: Mael RB <[email protected]>
Signed-off-by: Mael RB <[email protected]>
Signed-off-by: Mael RB <[email protected]>
Signed-off-by: Mael RB <[email protected]>
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from an OpenFeature spec perspective, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Tracking in Swift

2 participants