-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add Tracking API #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @MaelRB, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the OpenFeature Swift SDK by integrating the Tracking API. This feature allows developers to associate user actions and application states with feature flag evaluations, which is vital for robust experimentation and collecting telemetry. The changes introduce new core components for tracking, seamlessly integrate them into existing client and provider interfaces without breaking changes, and ensure that evaluation contexts are correctly merged for comprehensive data capture during tracking events.
Highlights
- Tracking API Implementation: The OpenFeature Swift SDK now includes a comprehensive Tracking API, fully adhering to the OpenFeature specifications for associating user actions with feature flag evaluations.
- New Protocols and Structures: Introduced
TrackingandTrackingEventDetailsprotocols, along with theImmutableTrackingEventDetailsstruct, to define and manage tracking event data. - Client and Provider Integration: The
Clientprotocol now conforms toTracking, andOpenFeatureClienthas been extended withtrackmethods. TheFeatureProviderprotocol includes a newtrackmethod with a default no-op implementation for extensibility. - Evaluation Context Merging: Enhanced
OpenFeatureClientwith logic to merge API-level and invocation-level evaluation contexts when reporting track events, ensuring comprehensive context capture. - Documentation and Tests: The
README.mdhas been updated to reflect the availability of the Tracking API with code examples. New unit tests have been added to validate the tracking functionality, context merging, and theImmutableTrackingEventDetailsstruct.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
b5ccc99 to
9e46ebf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the Tracking API, aligning the Swift SDK with the OpenFeature specification. The changes include new protocols (Tracking, TrackingEventDetails), concrete implementations (ImmutableTrackingEventDetails), and updates to the Client and FeatureProvider to support tracking events. The implementation is well-structured, with good separation of concerns and comprehensive test coverage for the new functionality. I've identified a potential issue in the context merging logic and a couple of areas for minor code simplification. Overall, this is a great addition to the SDK.
Signed-off-by: Mael RB <[email protected]>
Signed-off-by: Mael RB <[email protected]>
Signed-off-by: Mael RB <[email protected]>
Signed-off-by: Mael RB <[email protected]>
9e46ebf to
8746829
Compare
Signed-off-by: Mael RB <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from an OpenFeature spec perspective, thanks.
This PR
Related Issues
Fixes 1234523