feat: update provider status when provider emits events #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 97.10% 97.58% +0.47%
==========================================
Files 27 27
Lines 1176 1202 +26
==========================================
+ Hits 1142 1173 +31
+ Misses 34 29 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gruebel
reviewed
Apr 5, 2024
Member
gruebel
left a comment
gruebel
left a comment
There was a problem hiding this comment.
looks good, just a small suggestion
gruebel
approved these changes
Apr 5, 2024
Member
Author
|
@gruebel found a couple of bugs with the event logic around provider initialization/shutdown, all new changes are in the latest commit. |
beeme1mr
approved these changes
Apr 5, 2024
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Left a suggestion but overall looks good.
Member
|
@federicobond new changes look good 🙂 |
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also made
openfeature.provider.registrya private module and moved the registry singleton inside it.