Skip to content
This repository was archived by the owner on May 9, 2025. It is now read-only.

feat: adding CODEOWNERS file using maintainers #22

Merged
merged 2 commits into from
Apr 19, 2023
Merged

feat: adding CODEOWNERS file using maintainers #22

merged 2 commits into from
Apr 19, 2023

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 18, 2023

No description provided.

@Skarlso Skarlso requested a review from phoban01 April 18, 2023 14:24
Skarlso
Skarlso commented Apr 18, 2023
View reviewed changes
@Skarlso Skarlso force-pushed the add-maintainers branch 4 times, most recently from 1df3231 to 75c5af4 Compare April 18, 2023 15:18
@Skarlso Skarlso marked this pull request as ready for review April 18, 2023 20:02
@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 18, 2023

open-component-model/ocm-e2e-framework#8

@Skarlso Skarlso requested a review from jmickey April 19, 2023 06:33
@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 19, 2023

With the new modification of deleting the repository on Codeowners addition error, we can now see our status.

Status:
  Conditions:
    Last Transition Time:  2023-04-19T07:41:33Z
    Message:               failed to add CODEOWNERS file: illegal base64 data at input byte 0
    Observed Generation:   1
    Reason:                RepositoryCreateFailed
    Status:                False
    Type:                  Ready
Events:                    <none>

Previously, this would have been overwritten with another attempt at creating the repository, which did pass previously since these steps are separate from each other.

jmickey
jmickey approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@jmickey jmickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skarlso Skarlso merged commit b1c3f0d into main Apr 19, 2023
@Skarlso Skarlso deleted the add-maintainers branch April 19, 2023 10:34
@Skarlso Skarlso mentioned this pull request Apr 19, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@phoban01 phoban01 phoban01 approved these changes

@jmickey jmickey jmickey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skarlso @phoban01 @jmickey