Apply suggestions from code review

Skarlso · phoban01 · web-flow · commit 89269b59a148 · 2023-03-22T08:25:15.000+01:00
Co-authored-by: Piaras Hoban &lt;4415593+phoban01@users.noreply.github.com&gt;
diff --git a/api/v1alpha1/condition_types.go b/api/v1alpha1/condition_types.go
@@ -13,7 +13,7 @@ const (
 	SnapshotGetFailedReason = "SnapshotGetFailed"
 
 	// AuthenticateGetFailedReason is used when the needed authentication does not exist.
-	AuthenticateGetFailedReason = "AuthenticateGetFailed"
+	CredentialsNotFoundReason = "CredentialsNotFound"
 
 	// GitRepositoryPushFailedReason is used when the needed pushing to a git repository failed.
 	GitRepositoryPushFailedReason = "GitRepositoryPushFailed"
diff --git a/controllers/gitsync_controller.go b/controllers/gitsync_controller.go
@@ -145,7 +145,7 @@ func (r *GitSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 		Name:      obj.Spec.AuthRef.Name,
 	}, authSecret); err != nil {
 		retErr = fmt.Errorf("failed to find authentication secret: %w", err)
-		conditions.MarkFalse(obj, meta.ReadyCondition, v1alpha1.AuthenticateGetFailedReason, retErr.Error())
+		conditions.MarkFalse(obj, meta.ReadyCondition, v1alpha1.CredentialsNotFoundReason, retErr.Error())
 
 		return ctrl.Result{}, retErr
 	}

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ func (r *GitSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct`
`145`	`145`	`Name: obj.Spec.AuthRef.Name,`
`146`	`146`	`}, authSecret); err != nil {`
`147`	`147`	`retErr = fmt.Errorf("failed to find authentication secret: %w", err)`
`148`		`- conditions.MarkFalse(obj, meta.ReadyCondition, v1alpha1.AuthenticateGetFailedReason, retErr.Error())`
	`148`	`+ conditions.MarkFalse(obj, meta.ReadyCondition, v1alpha1.CredentialsNotFoundReason, retErr.Error())`
`149`	`149`
`150`	`150`	`return ctrl.Result{}, retErr`
`151`	`151`	`}`