fix: allowing domain to be added including a scheme

Author: Skarlso

apis/mpas/v1alpha1/repository_types.go

@@ -102,7 +102,7 @@ func (in Repository) GetRepositoryURL() string {
 			return fmt.Sprintf("%s:%s/%s", in.Spec.Domain, in.Spec.Owner, in.GetName())
 		}
 
-		return fmt.Sprintf("%s/%s/%s", in.Spec.Domain, in.Spec.Owner, in.GetName())
+		return fmt.Sprintf("https://%s/%s/%s", in.Spec.Domain, in.Spec.Owner, in.GetName())
 	}
 
 	domain := ""

controllers/mpas/repository_controller.go

@@ -8,6 +8,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"net/url"
 
 	eventv1 "github.com/fluxcd/pkg/apis/event/v1beta1"
 	"github.com/fluxcd/pkg/apis/meta"
@@ -55,6 +56,17 @@ func (r *RepositoryReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		return ctrl.Result{}, fmt.Errorf("failed to get component object: %w", err)
 	}
 
+	if obj.Spec.Domain != "" {
+		u, err := url.Parse(obj.Spec.Domain)
+		if err != nil {
+			return ctrl.Result{}, fmt.Errorf("failed to parse domain url: %w", err)
+		}
+
+		if u.Scheme != "" {
+			return ctrl.Result{}, fmt.Errorf("domain URL must be provided without a scheme")
+		}
+	}
+
 	patchHelper := patch.NewSerialPatcher(obj, r.Client)
 
 	// Always attempt to patch the object and status after each reconciliation.

pkg/providers/github/github.go

@@ -88,9 +88,9 @@ func (c *Client) CreateBranchProtection(ctx context.Context, obj mpasv1alpha1.Re
 	if err != nil {
 		return fmt.Errorf("failed to retrieve token: %w", err)
 	}
+
 	ts := oauth2.StaticTokenSource(&oauth2.Token{AccessToken: string(token)})
 	tc := oauth2.NewClient(context.Background(), ts)
-
 	g := ggithub.NewClient(tc)
 
 	if _, _, err := g.Repositories.UpdateBranchProtection(ctx, obj.Spec.Owner, obj.Name, obj.Spec.DefaultBranch, &ggithub.ProtectionRequest{