Skip to content

Conversation

@pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Nov 26, 2024

Found by memcheck. The BuildFlagPtr vector was being populated by the backing data of temporarily created std::string.

Found by memcheck. The BuildFlagPtr vector was being
populated by the backing data of temporarily created
std::string.
@pbalcer pbalcer requested a review from a team as a code owner November 26, 2024 14:43
@github-actions github-actions bot added the level-zero L0 adapter specific issues label Nov 26, 2024
@pbalcer pbalcer added v0.11.x Include in the v0.11.x release and removed level-zero L0 adapter specific issues labels Nov 26, 2024
@pbalcer pbalcer added the level-zero L0 adapter specific issues label Nov 26, 2024
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there was another issue related to this bug that this should resolve.

@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Dec 3, 2024
@nrspruit
Copy link
Contributor

nrspruit commented Dec 3, 2024

This is confirmed to resolve issues in a customer bug, this is ready to merge to the 0.11.x release branch.

@kbenzie kbenzie merged commit 1a6ad18 into oneapi-src:main Dec 9, 2024
74 of 75 checks passed
@kbenzie
Copy link
Contributor

kbenzie commented Dec 9, 2024

Changes will be pulled in by intel/llvm#16233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants