Change urSuggestMaxCooperativeGroupCountExp to accept ND size parameter
#2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
github-actions
bot
added
loader
Signed-off-by: Michael Aziz <[email protected]>
steffenlarsen
approved these changes
Nov 13, 2024
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
CUDA and HIP changes LGTM!
Contributor
Author
|
@nrspruit, do you know why the checks for this PR are failing? The logs show the following CMake error: I don't believe this error is caused by my changes but I'm also not sure if it's failing in any other PR. |
aarongreig
approved these changes
Nov 26, 2024
Contributor
Author
|
All SYCL tests for this PR are passing in intel/llvm#16051. |
Contributor
if you can get that PR approved by |
Contributor
Author
|
@aarongreig, there's now an approval from |
Contributor
I've added the label, just to manage your expectations: the queue is quite busy at the moment so there will be a wait to get merged |
martygrant
added a commit
to 0x12CC/llvm
that referenced
this pull request
Dec 6, 2024
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 6, 2024
Update calls to `urKernelSuggestMaxCooperativeGroupCountExp` to match the changes in oneapi-src/unified-runtime#2316. This PR also implements the `range<1>` and `range<2>` overloads of the `ext_oneapi_get_info` API from [sycl_ext_oneapi_launch_queries](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_launch_queries.asciidoc). --------- Signed-off-by: Michael Aziz <[email protected]> Co-authored-by: Martin Morrison-Grant <[email protected]>
KornevNikita
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 25, 2025
Update calls to `urKernelSuggestMaxCooperativeGroupCountExp` to match the changes in oneapi-src/unified-runtime#2316. This PR also implements the `range<1>` and `range<2>` overloads of the `ext_oneapi_get_info` API from [sycl_ext_oneapi_launch_queries](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_launch_queries.asciidoc). --------- Signed-off-by: Michael Aziz <[email protected]> Co-authored-by: Martin Morrison-Grant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The L0 API requires calling
zeKernelSetGroupSizebeforezeKernelSuggestMaxCooperativeGroupCountto ensure that the query result is correct. This PR changesurSuggestMaxCooperativeGroupCountExpto accept a group size withuint32_t *pworkDimandconst size_t **ppLocalWorkSizeparameters.