[Command-Buffer] Fix update validation for L0 and OpenCL #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
EwanC
reviewed
Nov 6, 2024
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Probably a bit late, but can we write a UR CTS test that would've caught this
Contributor
Author
I have now added a test for it 👍 Has PVC been added to CI? If not, even this new test wouldn't have caught the bug unless it was run locally. |
fabiomestre
force-pushed
the
fabio/fix_level_zero_updates
branch
from
3a78b63 to
8e032a7
Compare
fabiomestre
changed the title
EwanC
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where passing nullptr to hNewKernel results on UR_RESULT_ERROR_UNSUPPORTED_FEATURE being returned.
intel/llvm: https://github.com/intel/llvm/pull/15998/files