Remove decrementAndTestReferenceCount

Author: Bensuo

source/adapters/cuda/command_buffer.cpp

@@ -130,7 +130,7 @@ urCommandBufferRetainExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
 
 UR_APIEXPORT ur_result_t UR_APICALL
 urCommandBufferReleaseExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
-  if (!hCommandBuffer->decrementAndTestReferenceCount())
+  if (hCommandBuffer->decrementReferenceCount() != 0)
     return UR_RESULT_SUCCESS;
 
   delete hCommandBuffer;

source/adapters/cuda/command_buffer.hpp

@@ -222,20 +222,4 @@ struct ur_exp_command_buffer_handle_t_ {
   // Used when releasing an object.
   uint32_t decrementReferenceCount() noexcept { return --RefCount; }
   uint32_t getReferenceCount() const noexcept { return RefCount; }
-  // This method allows to guard a code which needs to be executed when object's
-  // ref count becomes zero after release. It is important to notice that only a
-  // single thread can pass through this check. This is true because of several
-  // reasons:
-  //   1. Decrement operation is executed atomically.
-  //   2. It is not allowed to retain an object after its refcount reaches zero.
-  //   3. It is not allowed to release an object more times than the value of
-  //   the ref count.
-  // 2. and 3. basically means that we can't use an object at all as soon as its
-  // refcount reaches zero. Using this check guarantees that code for deleting
-  // an object and releasing its resources is executed once by a single thread
-  // and we don't need to use any mutexes to guard access to this object in the
-  // scope after this check. Of course if we access another objects in this code
-  // (not the one which is being deleted) then access to these objects must be
-  // guarded, for example with a mutex.
-  bool decrementAndTestReferenceCount() { return --RefCount == 0; }
 };