Apply suggestions from code review

Co-authored-by: Alvaro Fuentes <[email protected]>

Author: yajo

src/util/specific.py

@@ -156,17 +156,19 @@ def translation2jsonb_all_missing(cr):
 
     :return: Converted fields.
     """
+    if not util.version_gte("16.0"):
+        raise UpgradeError("JSONB translations are only available from Odoo 16")
     _env = env(cr)
     fields = []
     cr.execute(
         """
-        SELECT STRING_TO_ARRAY(name, ','), ARRAY_AGG(DISTINCT lang)
-        FROM _ir_translation
-        WHERE
-            type IN ('model', 'model_terms')
-            AND name LIKE '%,%'
-            AND lang != 'en_US'
-        GROUP BY name
+        SELECT STRING_TO_ARRAY(name, ','),
+               ARRAY_AGG(DISTINCT lang)
+          FROM _ir_translation
+         WHERE type IN ('model', 'model_terms')
+           AND name LIKE '%,%'
+           AND lang != 'en_US'
+         GROUP BY name
         """
     )
     for (mname, fname), langs in cr.fetchall():
@@ -186,10 +188,8 @@ def translation2jsonb_all_missing(cr):
             continue
         # Check if the field is already converted
         cr.execute(
-            sql.SQL("SELECT 1 FROM {} WHERE {} ?| %s LIMIT 1").format(
-                sql.Identifier(model._table), sql.Identifier(fname)
-            ),
-            (langs,),
+            format_query(cr, "SELECT 1 FROM {} WHERE {} ?| %s LIMIT 1", model._table, fname),
+            [langs],
         )
         if not cr.rowcount:
             fields.append(field)
@@ -205,6 +205,8 @@ def translation2jsonb(cr, *fields):
     :param odoo.fields.Field fields: Fields to convert.
     :return: Converted fields.
     """
+    if not util.version_gte("16.0"):
+        ...
     all_cleanup_queries = []
     for field in fields:
         _logger.info("Migrating translations for field %s in model %s", field.name, field.model_name)