Skip to content

[IMP] Quality: Take a Picture check Shop Floor #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] Quality: Take a Picture check Shop Floor #6917

wants to merge 1 commit into from

Conversation

@hojo-odoo
Copy link
Contributor

@hojo-odoo hojo-odoo commented Dec 12, 2023

This PR replaces the tablet view workflow in the Take a Picture check doc with a new section detailing the workflow for the Shop Floor module.

@robodoo
Copy link
Collaborator

robodoo commented Dec 12, 2023

Pull request status dashboard.

@hojo-odoo hojo-odoo changed the base branch from saas-16.4 to 16.0 December 12, 2023 20:59
@hojo-odoo hojo-odoo changed the base branch from 16.0 to saas-16.4 December 12, 2023 21:00
@C3POdoo C3POdoo requested a review from a team December 12, 2023 21:01
Felicious
Felicious approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @hojo-odoo ! Great update 😄

@hojo-odoo hojo-odoo requested a review from a team January 17, 2024 20:54
meng-odoo
meng-odoo approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo, great job on this doc! It's written very clearly. I just caught a couple quick fixes :)

@hojo-odoo hojo-odoo force-pushed the 16.4-quality-picture-check-shop-floor-hojo branch from 0bf47e1 to 2e34f39 Compare January 23, 2024 21:51
@hojo-odoo hojo-odoo requested a review from a team January 23, 2024 21:55
ksc-odoo
ksc-odoo suggested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hojo-odoo just finished Final Reviewing this one. Awesome work. Just a couple things that need a minor adjustment here and there. Once you knock out those quick changes, tag me again, and I'll approve and move this one forward. Thanks!

@hojo-odoo hojo-odoo force-pushed the 16.4-quality-picture-check-shop-floor-hojo branch from 2e34f39 to b6a2ffe Compare January 25, 2024 17:53
@hojo-odoo
Copy link
Contributor Author

hojo-odoo commented Jan 25, 2024

@samueljlieber This is ready for technical review.

@hojo-odoo hojo-odoo changed the title [IMP] Add Take a Picture check Shop Floor content [IMP] Quality: Take a Picture check Shop Floor Jan 25, 2024
ksc-odoo
ksc-odoo suggested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty @hojo-odoo just a couple quick fixes and then it should be good to approve and move on. Thanks again for all your hard work. Awesome job! 👍

@hojo-odoo hojo-odoo force-pushed the 16.4-quality-picture-check-shop-floor-hojo branch from b6a2ffe to e0d7877 Compare January 25, 2024 19:38
ksc-odoo
ksc-odoo approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully approve 👍 thanks for making the adjustments, @hojo-odoo --- this one is ready for tech review @samueljlieber 👍

samueljlieber
samueljlieber approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo, nice job on the improvements in this PR. I have only a single change, please see below. I will push up this change and move this PR forward. Approving now!

content/applications/inventory_and_mrp/quality/quality_check_types/picture_check.rst Outdated
Comment on lines 158 to 159
If a quality alert must be created, exit the pop-up window by clicking the :guilabel:`X` button in
the top-right corner.
Copy link
Contributor

@samueljlieber samueljlieber Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether or not you use an icon here is up to you, but adding the descriptor is necessary to stay consistent.

Suggested change
If a quality alert must be created, exit the pop-up window by clicking the :guilabel:`X` button in
the top-right corner.
If a quality alert must be created, exit the pop-up window by clicking the :guilabel:`X (close)`
button in the top-right corner.

@samueljlieber samueljlieber force-pushed the 16.4-quality-picture-check-shop-floor-hojo branch from e0d7877 to 548eca3 Compare January 25, 2024 21:40
@samueljlieber
Copy link
Contributor

samueljlieber commented Jan 25, 2024

@StraubCreative this PR is good to go 👍

StraubCreative
StraubCreative approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @hojo-odoo
one comment for your review regarding the icon again

@robodoo delegate=hojo-odoo

@hojo-odoo hojo-odoo force-pushed the 16.4-quality-picture-check-shop-floor-hojo branch from 548eca3 to c6bad96 Compare January 26, 2024 21:24
@hojo-odoo hojo-odoo force-pushed the 16.4-quality-picture-check-shop-floor-hojo branch from c6bad96 to 3970013 Compare January 26, 2024 21:32
@hojo-odoo
Copy link
Contributor Author

hojo-odoo commented Jan 26, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 26, 2024
[IMP] Quality: Take a Picture check Shop Floor
93b47e7 
closes #6917

Signed-off-by: John Holton (hojo) <[email protected]>
@robodoo robodoo closed this Jan 26, 2024
This was referenced Jan 26, 2024
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Jan 30, 2024

@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@Felicious Felicious Felicious approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+2 more reviewers

@ksc-odoo ksc-odoo ksc-odoo approved these changes

@meng-odoo meng-odoo meng-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@hojo-odoo @robodoo @samueljlieber @fw-bot @StraubCreative @Felicious @ksc-odoo @meng-odoo