Skip to content

Conversation

@theRealThagomizer
Copy link
Contributor

Updated language on the subscriptions page around "align to period start"

https://www.odoo.com/odoo/all-tasks/4610815

This 18.0 can FWP up to master.

@robodoo
Copy link
Collaborator

robodoo commented Oct 2, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 2, 2025 17:26
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @theRealThagomizer ! Nice job digging into the billing period behavior and double-checking it with the SME! (:

I left one optional note for added specificity, since I wasn’t completely sure about the billing period detail.

I also noticed the automatic checks failed because of a trailing whitespace. You can catch this in the future with this VScode extension. (I’ve added it to the onboarding setup doc too!)

For next time, just make sure the CI checks pass before tagging the reviewer.

@robodoo delegate+

@theRealThagomizer
Copy link
Contributor Author

This looks good to me, @theRealThagomizer ! Nice job digging into the billing period behavior and double-checking it with the SME! (:

I left one optional note for added specificity, since I wasn’t completely sure about the billing period detail.

I also noticed the automatic checks failed because of a trailing whitespace. You can catch this in the future with this VScode extension. (I’ve added it to the onboarding setup doc too!)

For next time, just make sure the CI checks pass before tagging the reviewer.

Thanks for the feedback, Felicia! I implemented your commit. I also downloaded the extension you suggested and will start using it going forward.

@theRealThagomizer theRealThagomizer force-pushed the 18.0-subscriptions-update-align-to-period-thjud branch from 4193048 to ad510b3 Compare October 3, 2025 20:14
@theRealThagomizer
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants