Skip to content

Commit bcc83f9

Browse files
committed
[REM] core: profiler SyncCollector
closes #14774 Related: odoo/odoo#229936 Related: odoo/upgrade#8548 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
1 parent 764dc91 commit bcc83f9

File tree

1 file changed

+4
-22
lines changed

1 file changed

+4
-22
lines changed

content/developer/reference/backend/performance.rst

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,7 @@ can access from the top menu.
160160

161161
.. important::
162162
Even though the profiler has been designed to be as light as possible, it can still impact
163-
performance, especially when using the :ref:`Sync collector
164-
<performance/profiling/collectors/sync>`. Keep that in mind when analyzing speedscope results.
163+
performance. Keep that in mind when analyzing speedscope results.
165164

166165
.. _performance/profiling/collectors:
167166

@@ -175,7 +174,7 @@ individually enabled from the user interface through their dedicated toggle butt
175174
:ref:`developer mode tools <developer-mode/tools>`, or from Python code through their key or
176175
class.
177176

178-
There are currently four collectors available in Odoo:
177+
There are currently three collectors available in Odoo:
179178

180179
.. list-table::
181180
:header-rows: 1
@@ -196,10 +195,6 @@ There are currently four collectors available in Odoo:
196195
- :guilabel:`Record qweb`
197196
- `qweb`
198197
- `QwebCollector`
199-
* - :ref:`Sync collector <performance/profiling/collectors/sync>`
200-
- No
201-
- `traces_sync`
202-
- `SyncCollector`
203198

204199
By default, the profiler enables the SQL and the Periodic collectors. Both when it is enabled from
205200
the user interface or Python code.
@@ -252,26 +247,13 @@ It is mainly useful for optimizing views.
252247

253248
.. autoclass:: QwebCollector
254249

255-
.. _performance/profiling/collectors/sync:
256-
257-
Sync collector
258-
~~~~~~~~~~~~~~
259-
260-
This collector saves the stack for every function's call and return and runs on the same thread,
261-
which greatly impacts performance.
262-
263-
It can be useful to debug and understand complex flows, and follow their execution in the code. It
264-
is however not recommended for performance analysis because the overhead is high.
265-
266-
.. autoclass:: SyncCollector
267-
268250
.. _performance/profiling/pitfalls:
269251

270252
Performance pitfalls
271253
--------------------
272254

273-
- Be careful with randomness. Multiple executions may lead to different results. E.g., a garbage
274-
collector being triggered during execution.
255+
- Be careful with randomness. Multiple executions may lead to different results. E.g., other
256+
processes or threads running on the system during the profiling.
275257
- Be careful with blocking calls. In some cases, external `c_call` may take some time before
276258
releasing the GIL, thus leading to unexpected long frames with the :ref:`Periodic collector
277259
<performance/profiling/collectors/periodic>`. This should be detected by the profiler and give a

0 commit comments

Comments
 (0)