Skip to content

Commit df77c61

Browse files
committed
[FIX] website: generate language selector only when needed
This commit generates the language selector element only when multiple languages exist, avoiding an empty header list item that creates an unnecessary border or empty space. task-5150808 closes odoo#231256 Signed-off-by: Romaric Moyeuvre (romo) <[email protected]>
1 parent e6bf033 commit df77c61

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

addons/website/views/website_templates.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1045,8 +1045,8 @@
10451045
<div class="o_header_hide_on_scroll">
10461046
<div aria-label="Top" t-if="is_view_active('website.header_text_element') or is_view_active('website.header_social_links') or is_view_active('website.header_language_selector')" class="o_header_sales_two_top py-1">
10471047
<ul class="navbar-nav container d-grid h-100 px-3 o_grid_header_3_cols">
1048-
<!-- Return empty placeholder if the element is not active to keep the right layout -->
1049-
<li class="o_header_sales_two_lang_selector_placeholder" t-if="is_view_active('website.header_language_selector') == False"/>
1048+
<!-- Return empty placeholder if the element is not active or if there is only one language to keep the right layout -->
1049+
<li class="o_header_sales_two_lang_selector_placeholder" t-if="is_view_active('website.header_language_selector') == False or len(languages) == 1"/>
10501050
<!-- Language Selector -->
10511051
<t t-call="website.placeholder_header_language_selector">
10521052
<t t-set="_div_classes" t-valuef="d-flex align-items-center h-100"/>
@@ -2179,7 +2179,7 @@
21792179

21802180
<template id="header_language_selector" inherit_id="website.placeholder_header_language_selector" name="Header Language Selector" active="True">
21812181
<xpath expr="." position="inside">
2182-
<li data-name="Language Selector" t-attf-class="o_header_language_selector #{_item_class}">
2182+
<li t-if="len(languages) > 1" data-name="Language Selector" t-attf-class="o_header_language_selector #{_item_class}">
21832183
<t id="header_language_selector_call" t-call="portal.language_selector">
21842184
<t t-set="_div_classes" t-value="(_div_classes or '') + ' dropdown'"/>
21852185
</t>

0 commit comments

Comments
 (0)