[FIX] google_calendar: user-friendly error message on synchronisation fail

Give a chance to the user to solve the issue by himself
when the Google synchronization is failing,
by displaying the actual error returned by Google
regarding the error.

The case of the OPW behind this revision is
the synchronisation from odoo to google calendar
of an event with an attendee having an invalid email
address.

In such a case, Google returns the meaningful error:
"Invalid attendee email".

We better pass this information to the user,
along with the event causing the trouble,
so he gets a chance to solve the issue by himself.

I take into account the revision
67c281c
Multiple attempts have been done by Julien
to solve this issue genericly,
by catching the error and raising an `UserError`
in the helper `_do_request` directly,
but this caused various issues for methods
expecting `_do_request` to return `HTTPError`,
which suddenly returned `UserError` instead.

I therefore chose to catch the error directly in `create_an_event`,
which is only called at one place,
and this place doesn't expect to catch `HTTPError` exceptions.
(no `try...except...`)

opw-2334442

closes odoo#58696

Signed-off-by: Denis Ledoux (dle) <[email protected]>

Author: beledouxdenis

addons/google_calendar/i18n/google_calendar.pot

@@ -227,6 +227,12 @@ msgstr ""
 msgid "The account you are trying to synchronize (%s) is not the same as the last one used (%s)!"
 msgstr ""
 
+#. module: google_calendar
+#: code:addons/google_calendar/models/google_calendar.py:277
+#, python-format
+msgid "The event \"%s\", %s (ID: %s) cannot be synchronized because of the following error: %s"
+msgstr ""
+
 #. module: google_calendar
 #: model:ir.model.fields,field_description:google_calendar.field_res_users_google_calendar_token_validity
 msgid "Token Validity"

addons/google_calendar/models/google_calendar.py

@@ -12,6 +12,7 @@
 from werkzeug import urls
 
 from odoo import api, fields, models, tools, _
+from odoo.exceptions import UserError
 from odoo.osv import expression
 from odoo.tools import exception_to_unicode
 
@@ -263,7 +264,20 @@ def create_an_event(self, event):
         url = "/calendar/v3/calendars/%s/events?fields=%s&access_token=%s" % ('primary', urls.url_quote('id,updated'), self.get_token())
         headers = {'Content-type': 'application/json', 'Accept': 'text/plain'}
         data_json = json.dumps(data)
-        return self.env['google.service']._do_request(url, data_json, headers, type='POST')
+        try:
+            return self.env['google.service']._do_request(url, data_json, headers, type='POST')
+        except requests.HTTPError as e:
+            try:
+                response = e.response.json()
+                error = response.get('error', {}).get('message')
+            except Exception:
+                error = None
+            if not error:
+                raise e
+            message = _('The event "%s", %s (ID: %s) cannot be synchronized because of the following error: %s') % (
+                event.name, event.start, event.id, error
+            )
+            raise UserError(message)
 
     def delete_an_event(self, event_id):
         """ Delete the given event in primary calendar of google cal.