[REF] mail, web, *: replace deprecated asyncStep() in tests

The functions `asyncStep()` and `waitForSteps()` are deprecated. This
commit replace by equivalent code with newer syntax, i.e.
`expect.step()` and `expect.waitForStep()`.

closes odoo#232919

Related: odoo/enterprise#98004
Signed-off-by: Sébastien Theys (seb) <[email protected]>

Author: alexkuhn

addons/account/static/tests/account_move_form.test.js

@@ -4,10 +4,10 @@ import {
     openFormView,
     start,
     startServer,
-    triggerHotkey
+    triggerHotkey,
 } from "@mail/../tests/mail_test_helpers";
 import { expect, test } from "@odoo/hoot";
-import { asyncStep, contains, onRpc, waitForSteps } from "@web/../tests/web_test_helpers";
+import { contains, onRpc } from "@web/../tests/web_test_helpers";
 import { defineAccountModels } from "./account_test_helpers";
 
 defineAccountModels();
@@ -17,7 +17,7 @@ test("When I switch tabs, it saves", async () => {
     const accountMove = pyEnv["account.move"].create({ name: "move0" });
     await start();
     onRpc("account.move", "web_save", () => {
-        asyncStep("tab saved");
+        expect.step("tab saved");
     });
     await openFormView("account.move", accountMove, {
         arch: `<form js_class='account_move_form'>
@@ -34,16 +34,14 @@ test("When I switch tabs, it saves", async () => {
     await insertText("[name='name'] input", "somebody save me!");
     triggerHotkey("Enter");
     await click('a[name="aml_tab"]');
-    await waitForSteps(["tab saved"]);
+    await expect.waitForSteps(["tab saved"]);
 });
 
 test("Confirmation dialog on delete contains a warning", async () => {
     const pyEnv = await startServer();
     const accountMove = pyEnv["account.move"].create({ name: "move0" });
     await start();
-    onRpc("account.move", "check_move_sequence_chain", () => {
-        return false;
-    });
+    onRpc("account.move", "check_move_sequence_chain", () => false);
     await openFormView("account.move", accountMove, {
         arch: `<form js_class='account_move_form'>
             <sheet>
@@ -58,7 +56,8 @@ test("Confirmation dialog on delete contains a warning", async () => {
     });
     await contains(".o_cp_action_menus button").click();
     await contains(".o_menu_item:contains(Delete)").click();
-    expect(".o_dialog div.text-danger").toHaveText("This operation will create a gap in the sequence.", {
-        message: "warning message has been added in the dialog"
-    });
+    expect(".o_dialog div.text-danger").toHaveText(
+        "This operation will create a gap in the sequence.",
+        { message: "warning message has been added in the dialog" }
+    );
 });

addons/bus/static/tests/assets_watchdog.test.js

@@ -1,13 +1,6 @@
-import { describe, test } from "@odoo/hoot";
+import { describe, expect, test } from "@odoo/hoot";
 import { runAllTimers, waitFor } from "@odoo/hoot-dom";
-import {
-    asyncStep,
-    contains,
-    getService,
-    MockServer,
-    mountWithCleanup,
-    waitForSteps,
-} from "@web/../tests/web_test_helpers";
+import { contains, getService, MockServer, mountWithCleanup } from "@web/../tests/web_test_helpers";
 import { browser } from "@web/core/browser/browser";
 import { WebClient } from "@web/webclient/webclient";
 import { defineBusModels } from "./bus_test_helpers";
@@ -16,15 +9,15 @@ defineBusModels();
 describe.current.tags("desktop");
 
 test("can listen on bus and display notifications in DOM", async () => {
-    browser.location.addEventListener("reload", () => asyncStep("reload-page"));
+    browser.location.addEventListener("reload", () => expect.step("reload-page"));
     await mountWithCleanup(WebClient);
-    getService("bus_service").subscribe("bundle_changed", () => asyncStep("bundle_changed"));
+    getService("bus_service").subscribe("bundle_changed", () => expect.step("bundle_changed"));
     MockServer.env["bus.bus"]._sendone("broadcast", "bundle_changed", {
         server_version: "NEW_MAJOR_VERSION",
     });
-    await waitForSteps(["bundle_changed"]);
+    await expect.waitForSteps(["bundle_changed"]);
     await runAllTimers();
     await waitFor(".o_notification", { text: "The page appears to be out of date." });
     await contains(".o_notification button:contains(Refresh)").click();
-    await waitForSteps(["reload-page"]);
+    await expect.waitForSteps(["reload-page"]);
 });

addons/bus/static/tests/bus_monitoring_service.test.js

@@ -7,13 +7,11 @@ import { WEBSOCKET_CLOSE_CODES } from "@bus/workers/websocket_worker";
 import { describe, expect, test } from "@odoo/hoot";
 import { manuallyDispatchProgrammaticEvent, runAllTimers } from "@odoo/hoot-dom";
 import {
-    asyncStep,
     getService,
     makeMockEnv,
     MockServer,
     mockService,
     patchWithCleanup,
-    waitForSteps,
 } from "@web/../tests/web_test_helpers";
 
 defineBusModels();
@@ -26,7 +24,7 @@ function stepConnectionStateChanges() {
         },
         set isConnectionLost(value) {
             if (value !== this._isConnectionLost) {
-                asyncStep(`isConnectionLost - ${value}`);
+                expect.step(`isConnectionLost - ${value}`);
             }
             this._isConnectionLost = value;
         },
@@ -36,53 +34,53 @@ function stepConnectionStateChanges() {
 test("connection considered as lost after failed reconnect attempt", async () => {
     stepConnectionStateChanges();
     addBusServiceListeners(
-        ["BUS:CONNECT", () => asyncStep("BUS:CONNECT")],
-        ["BUS:DISCONNECT", () => asyncStep("BUS:DISCONNECT")]
+        ["BUS:CONNECT", () => expect.step("BUS:CONNECT")],
+        ["BUS:DISCONNECT", () => expect.step("BUS:DISCONNECT")]
     );
     await makeMockEnv();
-    await waitForSteps(["isConnectionLost - false", "BUS:CONNECT"]);
+    await expect.waitForSteps(["isConnectionLost - false", "BUS:CONNECT"]);
     const unlockWebsocket = lockWebsocketConnect();
     MockServer.env["bus.bus"]._simulateDisconnection(WEBSOCKET_CLOSE_CODES.ABNORMAL_CLOSURE);
-    await waitForSteps(["BUS:DISCONNECT"]);
+    await expect.waitForSteps(["BUS:DISCONNECT"]);
     await runAllTimers();
-    await waitForSteps(["isConnectionLost - true"]);
+    await expect.waitForSteps(["isConnectionLost - true"]);
     unlockWebsocket();
     await runAllTimers();
-    await waitForSteps(["isConnectionLost - false"]);
+    await expect.waitForSteps(["isConnectionLost - false"]);
 });
 
 test("brief disconect not considered lost", async () => {
     stepConnectionStateChanges();
     addBusServiceListeners(
-        ["BUS:CONNECT", () => asyncStep("BUS:CONNECT")],
-        ["BUS:DISCONNECT", () => asyncStep("BUS:DISCONNECT")],
-        ["BUS:RECONNECT", () => asyncStep("BUS:RECONNECT")]
+        ["BUS:CONNECT", () => expect.step("BUS:CONNECT")],
+        ["BUS:DISCONNECT", () => expect.step("BUS:DISCONNECT")],
+        ["BUS:RECONNECT", () => expect.step("BUS:RECONNECT")]
     );
     await makeMockEnv();
-    await waitForSteps(["isConnectionLost - false", "BUS:CONNECT"]);
+    await expect.waitForSteps(["isConnectionLost - false", "BUS:CONNECT"]);
     MockServer.env["bus.bus"]._simulateDisconnection(WEBSOCKET_CLOSE_CODES.SESSION_EXPIRED);
-    await waitForSteps(["BUS:DISCONNECT"]);
+    await expect.waitForSteps(["BUS:DISCONNECT"]);
     await runAllTimers();
-    await waitForSteps(["BUS:RECONNECT"]); // Only reconnect step, which means the monitoring state didn't change.
+    await expect.waitForSteps(["BUS:RECONNECT"]); // Only reconnect step, which means the monitoring state didn't change.
 });
 
 test("computer sleep doesn't mark connection as lost", async () => {
     stepConnectionStateChanges();
     addBusServiceListeners(
-        ["BUS:CONNECT", () => asyncStep("BUS:CONNECT")],
-        ["BUS:DISCONNECT", () => asyncStep("BUS:DISCONNECT")],
-        ["BUS:RECONNECT", () => asyncStep("BUS:RECONNECT")]
+        ["BUS:CONNECT", () => expect.step("BUS:CONNECT")],
+        ["BUS:DISCONNECT", () => expect.step("BUS:DISCONNECT")],
+        ["BUS:RECONNECT", () => expect.step("BUS:RECONNECT")]
     );
     await makeMockEnv();
-    await waitForSteps(["isConnectionLost - false", "BUS:CONNECT"]);
+    await expect.waitForSteps(["isConnectionLost - false", "BUS:CONNECT"]);
     const unlockWebsocket = lockWebsocketConnect();
     patchWithCleanup(navigator, { onLine: false });
     await manuallyDispatchProgrammaticEvent(window, "offline"); // Offline event is triggered when the computer goes to sleep.
-    await waitForSteps(["BUS:DISCONNECT"]);
+    await expect.waitForSteps(["BUS:DISCONNECT"]);
     patchWithCleanup(navigator, { onLine: true });
     await manuallyDispatchProgrammaticEvent(window, "online"); // Online event is triggered when the computer wakes up.
     unlockWebsocket();
     await runAllTimers();
-    await waitForSteps(["BUS:CONNECT"]);
+    await expect.waitForSteps(["BUS:CONNECT"]);
     expect(getService("bus.monitoring_service").isConnectionLost).toBe(false);
 });