Prefer public ExcelJS APIs #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
visnup
force-pushed
the
mbostock/xlsx-tweaks
branch
2 times, most recently
from
4193b19 to
fe6a1b4
Compare
Conflicts: src/xlsx.js
visnup
added a commit
that referenced
this pull request
Sep 16, 2021
* Update xlsx.js * Update xlsx.js * Use Object.create(null) * Prefer public ExcelJS APIs (#255) * Use Object.create(null) * Prefer public ExcelJS APIs * Use latest tap API * Coerce header row values to strings before fallback check * Update src/xlsx.js Co-authored-by: Mike Bostock <[email protected]> * Public API Co-authored-by: Visnu Pitiyanuvath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is ExcelJS as a devDependency ok? There was a previous risk in using a
mockWorkbookfunction in tests previously and this guarantees better compatibility. But it's a whole new library to bring in.