Skip to content

Commit 2399f09

Browse files
Considering notes of cachequality.com, manifest change for methods
1 parent 10cbf16 commit 2399f09

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "cache-visual-editor",
33
"printableName": "Cache Visual Editor",
44
"packageName": "VisualEditor",
5-
"version": "0.6.1",
5+
"version": "0.6.2",
66
"description": "Visual class editor for InterSystems Caché",
77
"main": "index.js",
88
"keywords": [

source/cache/Installer.cls

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ ClassMethod RegisterWebApplication(name As %String, spec) As %Status
4747
}
4848

4949
/// This method removes web application by app name.
50-
ClassMethod DeleteWebApplication(name As %String)
50+
ClassMethod DeleteWebApplication(name As %String) As %Status
5151
{
5252
$$$log("Moving to %SYS.")
5353
new $Namespace
@@ -68,7 +68,7 @@ ClassMethod DeleteWebApplication(name As %String)
6868
}
6969

7070
/// This method is invoked when a class is compiled.
71-
ClassMethod CreateProjection(cls As %String, ByRef params) As %Status
71+
ClassMethod CreateProjection() As %Status
7272
{
7373
do ..Init()
7474
#define log(%s) set installLog = installLog _ $case(installLog = "", 1: "", :$C(10)) _ %s write !, %s
@@ -92,7 +92,7 @@ ClassMethod CreateProjection(cls As %String, ByRef params) As %Status
9292
}
9393

9494
/// This method is invoked when a class is 'uncompiled'.
95-
ClassMethod RemoveProjection(cls As %String, ByRef params, recompile As %Boolean) As %Status
95+
ClassMethod RemoveProjection() As %Status
9696
{
9797
do ..Init()
9898
#define log(%s) set installLog = installLog _ $case(installLog = "", 1: "", :$C(10)) _ %s write !, %s

source/cache/REST/Informer.cls

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ ClassMethod Init() As %Status
3232
set data.namespace = $Namespace
3333
set data.namespaces = ..getAllNamespacesList()
3434
do data.%ToJSON(, "o")
35-
quit $$$OK
35+
return $$$OK
3636
}
3737

3838
/// This method returns all available data about the class.
@@ -59,9 +59,9 @@ ClassMethod GetClassData(className As %String) As %ZEN.proxyObject
5959
set props = ##class(%Dictionary.ClassDefinition).%OpenId("%Dictionary.ClassDefinition")
6060
for j=1:1:props.Properties.Count() {
6161
set pname = props.Properties.GetAt(j).Name
62-
set:((pname '= "parent")
63-
&& ('props.Properties.GetAt(j).Private)
64-
&& ('$IsObject($PROPERTY(class, pname)))) $PROPERTY(oClass, pname) = $PROPERTY(class, pname)
62+
if ((pname '= "parent") && ('props.Properties.GetAt(j).Private) && ('$IsObject($PROPERTY(class, pname)))) {
63+
set $PROPERTY(oClass, pname) = $PROPERTY(class, pname)
64+
}
6565
}
6666
if (oClass.TimeChanged) { set oClass.TimeChanged = $zdatetime(oClass.TimeChanged) }
6767
if (oClass.TimeCreated) { set oClass.TimeCreated = $zdatetime(oClass.TimeCreated) }
@@ -102,7 +102,7 @@ ClassMethod GetClassData(className As %String) As %ZEN.proxyObject
102102
set met = class.Methods.GetAt(i)
103103
for j=1:1:props.Properties.Count() {
104104
set pname = props.Properties.GetAt(j).Name
105-
set:((pname '= "parent") && (pname '= "Implementation")) $PROPERTY(oMeth, pname) = $PROPERTY(met, pname)
105+
set:(pname '= "parent") $PROPERTY(oMeth, pname) = $PROPERTY(met, pname)
106106
}
107107
do oMethods.%DispatchSetProperty(met.Name, oMeth)
108108
}

source/client/js/classEditor/class/MANIFEST.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,9 @@ export default {
394394
default: 0,
395395
type: "boolean"
396396
},
397+
Implementation: {
398+
ignore: true
399+
},
397400
Name: {
398401
type: "string",
399402
required: true,

0 commit comments

Comments
 (0)