Skip to content

WWW-Authenticate headers when token authentication fails #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

WWW-Authenticate headers when token authentication fails #555

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb0362c
WWW-Authenticate headers
luckv Feb 23, 2019
553af12
Use util.format because es6 string template is not supported
luckv Feb 23, 2019
7a61fcd
eslint fix
luckv Feb 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/handlers/authenticate-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ var Request = require('../request');
var Response = require('../response');
var ServerError = require('../errors/server-error');
var UnauthorizedRequestError = require('../errors/unauthorized-request-error');
var utilFormat = require('util').format;

/**
* Constructor.
Expand Down Expand Up @@ -87,12 +88,21 @@ AuthenticateHandler.prototype.handle = function(request, response) {
return this.updateResponse(response, token);
})
.catch(function(e) {
// Include the "WWW-Authenticate" response header field if the client
// lacks any authentication information.
// Include the "WWW-Authenticate" response header field if the token authentication fails
//
// @see https://tools.ietf.org/html/rfc6750#section-3.1
if (e instanceof UnauthorizedRequestError) {
response.set('WWW-Authenticate', 'Bearer realm="Service"');
if (e instanceof InvalidRequestError || e instanceof InvalidTokenError || e instanceof InsufficientScopeError || e instanceof UnauthorizedRequestError) {

if(e instanceof UnauthorizedRequestError)
{response.set('WWW-Authenticate', 'Bearer realm="Service"');}
else
{
if(e.message)
{response.set('WWW-Authenticate', utilFormat('Bearer realm="Service",error="%s",error_description="%s"',e.name,e.message));}
else
{response.set('WWW-Authenticate', utilFormat('Bearer realm="Service",error="%s"', e.name));}
}

}

if (!(e instanceof OAuthError)) {
Expand Down