fix(agenda): respect start on weekday from custom agenda command

Closes #919

Author: kristijanhusak

lua/orgmode/agenda/types/agenda.lua

@@ -69,13 +69,13 @@ function OrgAgendaType:new(opts)
     to = nil,
     clock_report = nil,
     show_clock_report = opts.show_clock_report or false,
-    start_on_weekday = opts.start_on_weekday or config.org_agenda_start_on_weekday,
-    start_day = opts.start_day or config.org_agenda_start_day,
+    start_on_weekday = utils.if_nil(opts.start_on_weekday, config.org_agenda_start_on_weekday),
+    start_day = utils.if_nil(opts.start_day, config.org_agenda_start_day),
     agenda_files = opts.agenda_files,
     header = opts.header,
     sorting_strategy = opts.sorting_strategy or vim.tbl_get(config.org_agenda_sorting_strategy, 'agenda') or {},
     id = opts.id,
-    remove_tags = type(opts.remove_tags) == 'boolean' and opts.remove_tags or config.org_agenda_remove_tags,
+    remove_tags = utils.if_nil(opts.remove_tags, config.org_agenda_remove_tags),
   }
   data.valid_filters = vim.tbl_filter(function(filter)
     return filter and true or false

lua/orgmode/config/_meta.lua

@@ -13,7 +13,7 @@
 ---@class OrgAgendaCustomCommandAgenda:OrgAgendaCustomCommandTypeInterface
 ---@field org_agenda_span? OrgAgendaSpan Default: 'week'
 ---@field org_agenda_start_day? string Modifier from today, example '+1d'
----@field org_agenda_start_on_weekday? number
+---@field org_agenda_start_on_weekday? number | false
 
 ---@class OrgAgendaCustomCommandTags:OrgAgendaCustomCommandTypeInterface
 ---@field match? string

lua/orgmode/utils/init.lua

@@ -635,4 +635,19 @@ function utils.notify(msg, opts)
   vim.notify(message, vim.log.levels[opts.level:upper()], opts)
 end
 
+---Return first non-nil value
+---@generic T
+---@param ... T
+---@return T
+function utils.if_nil(...)
+  local nargs = select('#', ...)
+  for i = 1, nargs do
+    local v = select(i, ...)
+    if v ~= nil then
+      return v
+    end
+  end
+  return nil
+end
+
 return utils