Fix quaddtype debug symbols #12
Conversation
| Py_INCREF(given_descrs[1]); | ||
| loop_descrs[1] = given_descrs[1]; | ||
| return NPY_NO_CASTING; | ||
| return NPY_SAFE_CASTING; |
There was a problem hiding this comment.
You know that you don't have any byte-swaps or so, so this is always NO_CASTING. In principle, you could always return the singleton instance also. (The only reason NumPy has more instances is byte-swapping and metadata, which you don't have to support.)
Bu it's fine to just delete it for this DType really.
The function currently doesn't fill in the output loop_descrs[2]?
|
If you'd like, please feel free to add some tests for |
|
No problem, and thanks for the feedback to you both. I'm still filling out the implementation, so I'll definitely add tests for this now. |
No description provided.