use unsigned char in ucs4_character_is_ascii

ngoldbaum · ngoldbaum · commit bcbc0c7b273a · 2022-12-13T13:28:39.000-07:00
diff --git a/asciidtype/asciidtype/src/casts.c b/asciidtype/asciidtype/src/casts.c
@@ -109,9 +109,9 @@ unicode_to_ascii_resolve_descriptors(PyObject *NPY_UNUSED(self),
 static int
 ucs4_character_is_ascii(char *buffer)
 {
-    int first_char = buffer[0];
+    unsigned char first_char = buffer[0];
 
-    if (first_char < 0 || first_char > 127) {
+    if (first_char > 127) {
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,9 @@ unicode_to_ascii_resolve_descriptors(PyObject *NPY_UNUSED(self),`
`109`	`109`	`static int`
`110`	`110`	`ucs4_character_is_ascii(char *buffer)`
`111`	`111`	`{`
`112`		`- int first_char = buffer[0];`
	`112`	`+ unsigned char first_char = buffer[0];`
`113`	`113`
`114`		`- if (first_char < 0 \|\| first_char > 127) {`
	`114`	`+ if (first_char > 127) {`
`115`	`115`	`return -1;`
`116`	`116`	`}`
`117`	`117`