Improvements #7
Merged
Improvements #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Resizable component is unmounted before the initial resetTriggers timeout fires, an exception will be thrown when resetTriggers attempts to read from the DOM. Store a reference to the resetTriggers timeout ID and clear it before the component unmounts.
…tchings/react-component-resizable into ahutchings-clear-reset-triggers-timeout
Previously checkTriggers() read the dimensions from the DOM, and then dimensions were read again in order to get the values to pass to the onResize callback.
Read dimensions from the DOM only once per frame
denis-bunakalya
pushed a commit
to SpirentOrion/orion-react-component-resizable
that referenced
this pull request
Mar 29, 2022
…e-#6 nrako#6 added check for this.refs.resizable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes some of @ ahutchings changes and a bug fix for his changes.