Skip to content

Conversation

@ovo4096
Copy link
Contributor

@ovo4096 ovo4096 commented Aug 15, 2017

No description provided.

@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-cn Please review.

@lpinca
Copy link
Member

lpinca commented Aug 15, 2017

Can you please revert the changes applied to package-lock.json?

@ovo4096
Copy link
Contributor Author

ovo4096 commented Aug 15, 2017

I can, but why revert it?

@lpinca
Copy link
Member

lpinca commented Aug 15, 2017

@ovo4096 I think they are a mistake as I see no changes in package.json. Am I wrong?

@ovo4096
Copy link
Contributor Author

ovo4096 commented Aug 15, 2017

@lpinca I noticed that the fsevents that were deleted in package-lock.json are optionalDependencies of chokidar, and when i execute npm install it is not installed.

So that fsevents is require?

@lpinca
Copy link
Member

lpinca commented Aug 16, 2017

@ovo4096 I guess this is the result of running npm install in two different systems.

@ovo4096
Copy link
Contributor Author

ovo4096 commented Aug 17, 2017

@lpinca The problem should be this: npm/npm#17722

My system is Linux.

@lpinca
Copy link
Member

lpinca commented Aug 21, 2017

Ping @nodejs/nodejs-cn.

@terry-fei
Copy link

👍

@lpinca lpinca merged commit 19a0262 into nodejs:master Aug 22, 2017
@lpinca
Copy link
Member

lpinca commented Aug 22, 2017

@ovo4096 Thank you!

hackygolucky added a commit to hackygolucky/nodejs.org that referenced this pull request Sep 19, 2017
* 'master' of https://github.com/nodejs/nodejs.org: (22 commits)
  Add Myles as TSC Director (nodejs#1365)
  board: add Myles Borins (nodejs#1362)
  doc: fix some links in guides (nodejs#1363)
  blog: update 8.5.0 release
  blog: v8.5.0 release post (nodejs#1360)
  Update board.md (nodejs#1359)
  Merge Website WG Members and Collaborators 🎉 (nodejs#1357)
  Updated it translation for index.md (nodejs#1353)
  Get data from google doc for Announcements (nodejs#1332)
  fix silver section head and paypal location (nodejs#1355)
  layouts/in-the-news.hbs: Use JS standard style (nodejs#1352)
  blog: release post for v6.11.3
  Change member class (nodejs#1350)
  Fix wrongs Language Names in Working Groups page. (nodejs#1347)
  Remove current gold director (nodejs#1348)
  Fix instruction in dockerization guide. Issue nodejs#1344 (nodejs#1346)
  Update TSC member list (nodejs#1343)
  Update site.json of zh-cn locale (nodejs#1339)
  Update Silver member Directors for August 2017 (nodejs#1341)
  blog: add release post for v8.4.0 (nodejs#1340)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants