Skip to content

test: assert.throws() should include a RegExp #9976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: assert.throws() should include a RegExp #9976

wants to merge 1 commit into from

Conversation

cByst
Copy link
Contributor

@cByst cByst commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

Description of change

Assert.throws() in /test/parallel/test-child-process-detached.js should include a RegExp as the second argument.
Added RegExp to match on error.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@addaleax
Copy link
Member

addaleax commented Dec 5, 2016

CI: https://ci.nodejs.org/job/node-test-commit/6446/

@Trott
Copy link
Member

Trott commented Dec 7, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5279/

@italoacasas
Copy link

Landed in: f19579f

Thanks for the contribution.

@italoacasas italoacasas closed this Dec 7, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2016
@cByst @Trott
test: assert.throws() should include a RegExp
7d26c27 
PR-URL: nodejs#9976
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@cByst @addaleax
test: assert.throws() should include a RegExp
d8dc890 
PR-URL: #9976
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@cByst @addaleax
test: assert.throws() should include a RegExp
3c46ab6 
PR-URL: nodejs#9976
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@cByst @MylesBorins
test: assert.throws() should include a RegExp
28979f0 
PR-URL: #9976
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@princejwesley princejwesley princejwesley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.