From bb77126dcc547f2246c19698946ec456b15691fe Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 21 Oct 2021 16:22:35 -0400 Subject: [PATCH 1/3] http: add mising initialization Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson --- src/node_http_common-inl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node_http_common-inl.h b/src/node_http_common-inl.h index 6ddc99e7d4e897..ab33f0b46e1ec7 100644 --- a/src/node_http_common-inl.h +++ b/src/node_http_common-inl.h @@ -133,6 +133,7 @@ template NgHeader::NgHeader(NgHeader&& other) noexcept : name_(std::move(other.name_)), value_(std::move(other.value_)), + env_(std::move(other.env_)), token_(other.token_), flags_(other.flags_) { other.token_ = -1; From 81031b0c46569a5ee3625dc28edb08bc926f6a5a Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 21 Oct 2021 17:32:20 -0400 Subject: [PATCH 2/3] fixup: address compiler warning --- src/node_http_common-inl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_http_common-inl.h b/src/node_http_common-inl.h index ab33f0b46e1ec7..bf80790d306989 100644 --- a/src/node_http_common-inl.h +++ b/src/node_http_common-inl.h @@ -131,9 +131,9 @@ NgHeader::NgHeader( template NgHeader::NgHeader(NgHeader&& other) noexcept - : name_(std::move(other.name_)), + : env_(std::move(other.env_)), + name_(std::move(other.name_)), value_(std::move(other.value_)), - env_(std::move(other.env_)), token_(other.token_), flags_(other.flags_) { other.token_ = -1; From dc146f909dab6967614cca4d31ef250b1da5ee68 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 25 Oct 2021 10:53:19 -0400 Subject: [PATCH 3/3] fixup: remove unecessary move Signed-off-by: Michael Dawson --- src/node_http_common-inl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_http_common-inl.h b/src/node_http_common-inl.h index bf80790d306989..e78a6fdd2f95bd 100644 --- a/src/node_http_common-inl.h +++ b/src/node_http_common-inl.h @@ -131,7 +131,7 @@ NgHeader::NgHeader( template NgHeader::NgHeader(NgHeader&& other) noexcept - : env_(std::move(other.env_)), + : env_(other.env_), name_(std::move(other.name_)), value_(std::move(other.value_)), token_(other.token_),