util: improve prototype inspection using inspect() and showHidden
#31113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Dec 30, 2019
This comment has been minimized.
This comment has been minimized.
The fast path for the prototype inspection had a bug that caused some prototype properties to be skipped that should in fact be inspected.
BridgeAR
force-pushed
the
2019-12-27-fix-inspect-prototype
branch
from
f6bbe0f to
5546d95
Compare
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 1, 2020
|
CITGM out of caution: https://ci.nodejs.org/job/citgm-smoker/2177/ ✅ |
BridgeAR
added a commit
that referenced
this pull request
Jan 2, 2020
The fast path for the prototype inspection had a bug that caused some prototype properties to be skipped that should in fact be inspected. PR-URL: #31113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 7babffb 🎉 |
BridgeAR
added a commit
that referenced
this pull request
Jan 3, 2020
The fast path for the prototype inspection had a bug that caused some prototype properties to be skipped that should in fact be inspected. PR-URL: #31113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
|
This needs a backport or other previous PRs to be backported in order to land on v12.x-staging. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 22, 2020
The fast path for the prototype inspection had a bug that caused some prototype properties to be skipped that should in fact be inspected. PR-URL: nodejs#31113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
4 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jan 30, 2020
The fast path for the prototype inspection had a bug that caused some prototype properties to be skipped that should in fact be inspected. Backport-PR-URL: #31431 PR-URL: #31113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
The fast path for the prototype inspection had a bug that caused some prototype properties to be skipped that should in fact be inspected. Backport-PR-URL: #31431 PR-URL: #31113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes