From 8a217d76c0cca10cea3148bc020662a18dcad209 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 17 Oct 2017 21:50:25 -0700 Subject: [PATCH] test: fix inspector tests The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently. --- test/parallel/parallel.status | 4 ---- test/sequential/sequential.status | 4 ++++ .../test-inspector-async-hook-setup-at-inspect-brk.js | 0 .../test-inspector-async-hook-setup-at-signal.js | 0 .../test-inspector-async-hook-teardown-at-debug-end.js | 0 .../test-inspector-async-stack-traces-promise-then.js | 0 .../test-inspector-async-stack-traces-set-interval.js | 0 test/{parallel => sequential}/test-inspector-bindings.js | 0 test/{parallel => sequential}/test-inspector-break-e.js | 0 .../test-inspector-break-when-eval.js | 0 test/{parallel => sequential}/test-inspector-contexts.js | 0 .../{parallel => sequential}/test-inspector-debug-brk-flag.js | 0 test/{parallel => sequential}/test-inspector-debug-end.js | 0 test/{parallel => sequential}/test-inspector-exception.js | 0 test/{parallel => sequential}/test-inspector-invalid-args.js | 0 test/{parallel => sequential}/test-inspector-ip-detection.js | 0 test/{parallel => sequential}/test-inspector-module.js | 0 .../test-inspector-not-blocked-on-idle.js | 0 test/{parallel => sequential}/test-inspector-open.js | 0 .../test-inspector-port-zero-cluster.js | 0 test/{parallel => sequential}/test-inspector-port-zero.js | 0 .../test-inspector-scriptparsed-context.js | 0 .../test-inspector-stop-profile-after-done.js | 0 test/{parallel => sequential}/test-inspector-stops-no-file.js | 0 test/{parallel => sequential}/test-inspector.js | 0 25 files changed, 4 insertions(+), 4 deletions(-) rename test/{parallel => sequential}/test-inspector-async-hook-setup-at-inspect-brk.js (100%) rename test/{parallel => sequential}/test-inspector-async-hook-setup-at-signal.js (100%) rename test/{parallel => sequential}/test-inspector-async-hook-teardown-at-debug-end.js (100%) rename test/{parallel => sequential}/test-inspector-async-stack-traces-promise-then.js (100%) rename test/{parallel => sequential}/test-inspector-async-stack-traces-set-interval.js (100%) rename test/{parallel => sequential}/test-inspector-bindings.js (100%) rename test/{parallel => sequential}/test-inspector-break-e.js (100%) rename test/{parallel => sequential}/test-inspector-break-when-eval.js (100%) rename test/{parallel => sequential}/test-inspector-contexts.js (100%) rename test/{parallel => sequential}/test-inspector-debug-brk-flag.js (100%) rename test/{parallel => sequential}/test-inspector-debug-end.js (100%) rename test/{parallel => sequential}/test-inspector-exception.js (100%) rename test/{parallel => sequential}/test-inspector-invalid-args.js (100%) rename test/{parallel => sequential}/test-inspector-ip-detection.js (100%) rename test/{parallel => sequential}/test-inspector-module.js (100%) rename test/{parallel => sequential}/test-inspector-not-blocked-on-idle.js (100%) rename test/{parallel => sequential}/test-inspector-open.js (100%) rename test/{parallel => sequential}/test-inspector-port-zero-cluster.js (100%) rename test/{parallel => sequential}/test-inspector-port-zero.js (100%) rename test/{parallel => sequential}/test-inspector-scriptparsed-context.js (100%) rename test/{parallel => sequential}/test-inspector-stop-profile-after-done.js (100%) rename test/{parallel => sequential}/test-inspector-stops-no-file.js (100%) rename test/{parallel => sequential}/test-inspector.js (100%) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 1817501c98e8bb..2297aad9c88edf 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -7,9 +7,6 @@ prefix parallel [true] # This section applies to all platforms [$system==win32] -test-inspector-bindings : PASS, FLAKY -test-inspector-debug-end : PASS, FLAKY -test-inspector-stop-profile-after-done: PASS, FLAKY [$system==linux] @@ -23,4 +20,3 @@ test-npm-install: PASS,FLAKY [$system==freebsd] [$system==aix] -test-inspector-stop-profile-after-done: PASS, FLAKY diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 8467864395ff66..86095d16c30e0f 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -7,6 +7,9 @@ prefix sequential [true] # This section applies to all platforms [$system==win32] +test-inspector-bindings : PASS, FLAKY +test-inspector-debug-end : PASS, FLAKY +test-inspector-stop-profile-after-done: PASS, FLAKY [$system==linux] @@ -17,3 +20,4 @@ prefix sequential [$system==freebsd] [$system==aix] +test-inspector-stop-profile-after-done: PASS, FLAKY diff --git a/test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js b/test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js similarity index 100% rename from test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js rename to test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js diff --git a/test/parallel/test-inspector-async-hook-setup-at-signal.js b/test/sequential/test-inspector-async-hook-setup-at-signal.js similarity index 100% rename from test/parallel/test-inspector-async-hook-setup-at-signal.js rename to test/sequential/test-inspector-async-hook-setup-at-signal.js diff --git a/test/parallel/test-inspector-async-hook-teardown-at-debug-end.js b/test/sequential/test-inspector-async-hook-teardown-at-debug-end.js similarity index 100% rename from test/parallel/test-inspector-async-hook-teardown-at-debug-end.js rename to test/sequential/test-inspector-async-hook-teardown-at-debug-end.js diff --git a/test/parallel/test-inspector-async-stack-traces-promise-then.js b/test/sequential/test-inspector-async-stack-traces-promise-then.js similarity index 100% rename from test/parallel/test-inspector-async-stack-traces-promise-then.js rename to test/sequential/test-inspector-async-stack-traces-promise-then.js diff --git a/test/parallel/test-inspector-async-stack-traces-set-interval.js b/test/sequential/test-inspector-async-stack-traces-set-interval.js similarity index 100% rename from test/parallel/test-inspector-async-stack-traces-set-interval.js rename to test/sequential/test-inspector-async-stack-traces-set-interval.js diff --git a/test/parallel/test-inspector-bindings.js b/test/sequential/test-inspector-bindings.js similarity index 100% rename from test/parallel/test-inspector-bindings.js rename to test/sequential/test-inspector-bindings.js diff --git a/test/parallel/test-inspector-break-e.js b/test/sequential/test-inspector-break-e.js similarity index 100% rename from test/parallel/test-inspector-break-e.js rename to test/sequential/test-inspector-break-e.js diff --git a/test/parallel/test-inspector-break-when-eval.js b/test/sequential/test-inspector-break-when-eval.js similarity index 100% rename from test/parallel/test-inspector-break-when-eval.js rename to test/sequential/test-inspector-break-when-eval.js diff --git a/test/parallel/test-inspector-contexts.js b/test/sequential/test-inspector-contexts.js similarity index 100% rename from test/parallel/test-inspector-contexts.js rename to test/sequential/test-inspector-contexts.js diff --git a/test/parallel/test-inspector-debug-brk-flag.js b/test/sequential/test-inspector-debug-brk-flag.js similarity index 100% rename from test/parallel/test-inspector-debug-brk-flag.js rename to test/sequential/test-inspector-debug-brk-flag.js diff --git a/test/parallel/test-inspector-debug-end.js b/test/sequential/test-inspector-debug-end.js similarity index 100% rename from test/parallel/test-inspector-debug-end.js rename to test/sequential/test-inspector-debug-end.js diff --git a/test/parallel/test-inspector-exception.js b/test/sequential/test-inspector-exception.js similarity index 100% rename from test/parallel/test-inspector-exception.js rename to test/sequential/test-inspector-exception.js diff --git a/test/parallel/test-inspector-invalid-args.js b/test/sequential/test-inspector-invalid-args.js similarity index 100% rename from test/parallel/test-inspector-invalid-args.js rename to test/sequential/test-inspector-invalid-args.js diff --git a/test/parallel/test-inspector-ip-detection.js b/test/sequential/test-inspector-ip-detection.js similarity index 100% rename from test/parallel/test-inspector-ip-detection.js rename to test/sequential/test-inspector-ip-detection.js diff --git a/test/parallel/test-inspector-module.js b/test/sequential/test-inspector-module.js similarity index 100% rename from test/parallel/test-inspector-module.js rename to test/sequential/test-inspector-module.js diff --git a/test/parallel/test-inspector-not-blocked-on-idle.js b/test/sequential/test-inspector-not-blocked-on-idle.js similarity index 100% rename from test/parallel/test-inspector-not-blocked-on-idle.js rename to test/sequential/test-inspector-not-blocked-on-idle.js diff --git a/test/parallel/test-inspector-open.js b/test/sequential/test-inspector-open.js similarity index 100% rename from test/parallel/test-inspector-open.js rename to test/sequential/test-inspector-open.js diff --git a/test/parallel/test-inspector-port-zero-cluster.js b/test/sequential/test-inspector-port-zero-cluster.js similarity index 100% rename from test/parallel/test-inspector-port-zero-cluster.js rename to test/sequential/test-inspector-port-zero-cluster.js diff --git a/test/parallel/test-inspector-port-zero.js b/test/sequential/test-inspector-port-zero.js similarity index 100% rename from test/parallel/test-inspector-port-zero.js rename to test/sequential/test-inspector-port-zero.js diff --git a/test/parallel/test-inspector-scriptparsed-context.js b/test/sequential/test-inspector-scriptparsed-context.js similarity index 100% rename from test/parallel/test-inspector-scriptparsed-context.js rename to test/sequential/test-inspector-scriptparsed-context.js diff --git a/test/parallel/test-inspector-stop-profile-after-done.js b/test/sequential/test-inspector-stop-profile-after-done.js similarity index 100% rename from test/parallel/test-inspector-stop-profile-after-done.js rename to test/sequential/test-inspector-stop-profile-after-done.js diff --git a/test/parallel/test-inspector-stops-no-file.js b/test/sequential/test-inspector-stops-no-file.js similarity index 100% rename from test/parallel/test-inspector-stops-no-file.js rename to test/sequential/test-inspector-stops-no-file.js diff --git a/test/parallel/test-inspector.js b/test/sequential/test-inspector.js similarity index 100% rename from test/parallel/test-inspector.js rename to test/sequential/test-inspector.js