From d02ac76b2b0139d1cb1bc8cbc4a6907defb569e0 Mon Sep 17 00:00:00 2001 From: Chase Starr Date: Wed, 11 Jan 2017 19:45:23 -0800 Subject: [PATCH 1/2] test: improve tests in pummel/test-exec Add asset.strictEqual to stdout and stderr. Fixes no-unused-vars. --- test/pummel/test-exec.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/pummel/test-exec.js b/test/pummel/test-exec.js index b7f5ddebe7cb67..900a3594981edc 100644 --- a/test/pummel/test-exec.js +++ b/test/pummel/test-exec.js @@ -63,6 +63,8 @@ exec(SLEEP3_COMMAND, { timeout: 50 }, function(err, stdout, stderr) { assert.ok(err); assert.ok(err.killed); assert.strictEqual(err.signal, 'SIGTERM'); + assert.strictEqual(stdout, ""); + assert.strictEqual(stderr, ""); }); @@ -85,6 +87,8 @@ function killMeTwiceCallback(err, stdout, stderr) { assert.ok(err); assert.ok(err.killed); assert.strictEqual(err.signal, 'SIGTERM'); + assert.strictEqual(stdout, ""); + assert.strictEqual(stderr, ""); // the timeout should still be in effect console.log('\'sleep 3\' was already killed. Took %d ms', diff); @@ -96,6 +100,8 @@ exec('python -c "print 200000*\'C\'"', {maxBuffer: 1000}, function(err, stdout, stderr) { assert.ok(err); assert.ok(/maxBuffer/.test(err.message)); + assert.strictEqual(stdout, ""); + assert.strictEqual(stderr, ""); }); From 24a0619b7e90ef7798a326d7729365d26bcd7f30 Mon Sep 17 00:00:00 2001 From: Chase Starr Date: Wed, 11 Jan 2017 20:43:19 -0800 Subject: [PATCH 2/2] test: replace double quotes with single --- test/pummel/test-exec.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/pummel/test-exec.js b/test/pummel/test-exec.js index 900a3594981edc..131b214fc53f42 100644 --- a/test/pummel/test-exec.js +++ b/test/pummel/test-exec.js @@ -63,8 +63,8 @@ exec(SLEEP3_COMMAND, { timeout: 50 }, function(err, stdout, stderr) { assert.ok(err); assert.ok(err.killed); assert.strictEqual(err.signal, 'SIGTERM'); - assert.strictEqual(stdout, ""); - assert.strictEqual(stderr, ""); + assert.strictEqual(stdout, ''); + assert.strictEqual(stderr, ''); }); @@ -87,8 +87,8 @@ function killMeTwiceCallback(err, stdout, stderr) { assert.ok(err); assert.ok(err.killed); assert.strictEqual(err.signal, 'SIGTERM'); - assert.strictEqual(stdout, ""); - assert.strictEqual(stderr, ""); + assert.strictEqual(stdout, ''); + assert.strictEqual(stderr, ''); // the timeout should still be in effect console.log('\'sleep 3\' was already killed. Took %d ms', diff); @@ -100,8 +100,8 @@ exec('python -c "print 200000*\'C\'"', {maxBuffer: 1000}, function(err, stdout, stderr) { assert.ok(err); assert.ok(/maxBuffer/.test(err.message)); - assert.strictEqual(stdout, ""); - assert.strictEqual(stderr, ""); + assert.strictEqual(stdout, ''); + assert.strictEqual(stderr, ''); });