Skip to content

Commit c0d236f

Browse files
richardlaudanielleadams
authored andcommitted
build: make build-addons errors fail the build
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and then uses `touch` to update a timestamp file. Unconditionally calling `touch` was losing the exit code from `tools/doc/addon-verify.js` so any errors produced by that script were not failing the build. PR-URL: #38983 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f7724ab commit c0d236f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ test/addons/.docbuildstamp: $(DOCBUILDSTAMP_PREREQS) tools/doc/node_modules
352352
else \
353353
$(RM) -r test/addons/??_*/; \
354354
[ -x $(NODE) ] && $(NODE) $< || node $< ; \
355-
touch $@; \
355+
[ $$? -eq 0 ] && touch $@; \
356356
fi
357357

358358
ADDONS_BINDING_GYPS := \

0 commit comments

Comments
 (0)