worker: use correct ctor for error serialization

When serializing errors, use the error constructor that is
closest to the object itself in the prototype chain.

The previous practice of walking downwards meant that
`Error` would usually be the first constructor that is used,
even when a more specific one would be available/appropriate,
because it is the base class of the other common error types.

PR-URL: #25951
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>

Author: addaleax

lib/internal/error-serdes.js

@@ -80,7 +80,7 @@ function serializeError(error) {
     if (typeof error === 'object' &&
         ObjectPrototypeToString(error) === '[object Error]') {
       const constructors = GetConstructors(error);
-      for (var i = constructors.length - 1; i >= 0; i--) {
+      for (var i = 0; i < constructors.length; i++) {
         const name = GetName(constructors[i]);
         if (errorConstructorNames.has(name)) {
           try { error.stack; } catch {}

test/parallel/test-worker-syntax-error-file.js

@@ -10,6 +10,7 @@ if (!process.env.HAS_STARTED_WORKER) {
   const w = new Worker(fixtures.path('syntax', 'bad_syntax.js'));
   w.on('message', common.mustNotCall());
   w.on('error', common.mustCall((err) => {
+    assert.strictEqual(err.constructor, SyntaxError);
     assert(/SyntaxError/.test(err));
   }));
 } else {

test/parallel/test-worker-syntax-error.js

@@ -9,6 +9,7 @@ if (!process.env.HAS_STARTED_WORKER) {
   const w = new Worker('abc)', { eval: true });
   w.on('message', common.mustNotCall());
   w.on('error', common.mustCall((err) => {
+    assert.strictEqual(err.constructor, SyntaxError);
     assert(/SyntaxError/.test(err));
   }));
 } else {