assert: cap input size in myersDiff to avoid Int32Array overflow

PR-URL: #59578
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

Author: haramj

lib/internal/assert/myers_diff.js

@@ -6,6 +6,12 @@ const {
   StringPrototypeEndsWith,
 } = primordials;
 
+const {
+  codes: {
+    ERR_OUT_OF_RANGE,
+  },
+} = require('internal/errors');
+
 const colors = require('internal/util/colors');
 
 const kNopLinesToCollapse = 5;
@@ -29,7 +35,15 @@ function myersDiff(actual, expected, checkCommaDisparity = false) {
   const actualLength = actual.length;
   const expectedLength = expected.length;
   const max = actualLength + expectedLength;
-  // TODO(BridgeAR): Cap the input in case the values go beyond the limit of 2^31 - 1.
+
+  if (max > 2 ** 31 - 1) {
+    throw new ERR_OUT_OF_RANGE(
+      'myersDiff input size',
+      '< 2^31',
+      max,
+    );
+  }
+
   const v = new Int32Array(2 * max + 1);
   const trace = [];
 

test/parallel/test-assert-myers-diff.js

@@ -0,0 +1,25 @@
+// Flags: --expose-internals
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+
+const { myersDiff } = require('internal/assert/myers_diff');
+
+{
+  const arr1 = { length: 2 ** 31 - 1 };
+  const arr2 = { length: 2 };
+  const max = arr1.length + arr2.length;
+  assert.throws(
+    () => {
+      myersDiff(arr1, arr2);
+    },
+    common.expectsError({
+      code: 'ERR_OUT_OF_RANGE',
+      name: 'RangeError',
+      message: 'The value of "myersDiff input size" ' +
+                'is out of range. It must be < 2^31. ' +
+                `Received ${max}`
+    })
+  );
+}