feat: drop rimraf dependency

Author: lukekarrys

lib/clean.js

@@ -1,15 +1,17 @@
 'use strict'
 
-const rm = require('rimraf')
+const fs = require('fs')
 const log = require('./log')
 
-function clean (gyp, argv, callback) {
+async function clean (gyp, argv) {
   // Remove the 'build' dir
   const buildDir = 'build'
 
   log.verbose('clean', 'removing "%s" directory', buildDir)
-  rm(buildDir, callback)
+  await fs.promises.rm(buildDir, { recursive: true, force: true })
 }
 
-module.exports = clean
+module.exports = function (gyp, argv, callback) {
+  clean(gyp, argv).then(callback.bind(undefined, null), callback)
+}
 module.exports.usage = 'Removes any generated build files and the "out" dir'

lib/remove.js

@@ -1,12 +1,11 @@
 'use strict'
 
-const fs = require('fs')
-const rm = require('rimraf')
+const fs = require('fs').promises
 const path = require('path')
 const log = require('./log')
 const semver = require('semver')
 
-function remove (gyp, argv, callback) {
+async function remove (gyp, argv) {
   const devDir = gyp.devDir
   log.verbose('remove', 'using node-gyp dir:', devDir)
 
@@ -15,7 +14,7 @@ function remove (gyp, argv, callback) {
   log.verbose('remove', 'removing target version:', version)
 
   if (!version) {
-    return callback(new Error('You must specify a version number to remove. Ex: "' + process.version + '"'))
+    throw new Error('You must specify a version number to remove. Ex: "' + process.version + '"')
   }
 
   const versionSemver = semver.parse(version)
@@ -28,19 +27,19 @@ function remove (gyp, argv, callback) {
   log.verbose('remove', 'removing development files for version:', version)
 
   // first check if its even installed
-  fs.stat(versionPath, function (err) {
-    if (err) {
-      if (err.code === 'ENOENT') {
-        callback(null, 'version was already uninstalled: ' + version)
-      } else {
-        callback(err)
-      }
-      return
+  try {
+    await fs.stat(versionPath)
+  } catch (err) {
+    if (err.code === 'ENOENT') {
+      return 'version was already uninstalled: ' + version
     }
-    // Go ahead and delete the dir
-    rm(versionPath, callback)
-  })
+    throw err
+  }
+
+  await fs.rm(versionPath, { recursive: true, force: true })
 }
 
-module.exports = exports = remove
+module.exports = function (gyp, argv, callback) {
+  remove(gyp, argv).then(callback.bind(undefined, null), callback)
+}
 module.exports.usage = 'Removes the node development files for the specified version'

package.json

@@ -28,7 +28,6 @@
     "make-fetch-happen": "^11.0.2",
     "nopt": "^7.0.0",
     "proc-log": "^3.0.0",
-    "rimraf": "^3.0.2",
     "semver": "^7.3.5",
     "tar": "^6.1.2",
     "which": "^3.0.0"

test/test-download.js

@@ -9,7 +9,6 @@ const https = require('https')
 const install = require('../lib/install')
 const semver = require('semver')
 const devDir = require('./fixtures/common').devDir()
-const rimraf = require('rimraf')
 const gyp = require('../lib/node-gyp')
 const log = require('../lib/log')
 const certs = require('./fixtures/certs')
@@ -179,7 +178,7 @@ test('download headers (actual)', async (t) => {
   t.plan(12)
 
   const expectedDir = path.join(devDir, process.version.replace(/^v/, ''))
-  await util.promisify(rimraf)(expectedDir)
+  await fs.promises.rm(expectedDir, { recursive: true, force: true })
 
   const prog = gyp()
   prog.parseArgv([])