Move to es6 #58
Merged
Move to es6 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankapunkt
added
enhancement ✨
Closed
jwerre
suggested changes
Nov 11, 2021
Contributor
jwerre
left a comment
jwerre
left a comment
There was a problem hiding this comment.
There are a couple of spots that may be problematic where const is used instead of let.
jwerre
approved these changes
Nov 14, 2021
Contributor
|
@HappyZombies Can you approve this? |
Member
|
Approved! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades all code from ES5 to ES6, where possible.
Non-breaking.
Linked issue(s)
#54 and #5
Involved parts of the project
Every js file, including tests, plus
.eslintrcandpackage.jsonAdded tests?
Added npm scripts
lintandlint:fixwhich can now be used in ci as wellOAuth2 standard
No changes in behavior
Reproduction
$ git checkout move-to-es6 $ npm run lint $ npm run test