Fix critical scope validation bug #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jorenvandeweyer changed target to |
Member
Author
|
This can't be merged into 4.x since there is a complete different syntax. I'm creating later today a different PR that fixes this for the 4.x branch |
Member
|
@jorenvandeweyer that would be awesome! In turn we can target 5.x with this |
jankapunkt
approved these changes
Aug 26, 2023
This was referenced Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug mentioned in #64
Linked issue(s)
#64
Involved parts of the project
Scope validation
Added tests?
NA
OAuth2 standard
NA
Reproduction