From 66f8cda352467dc1b37f96342c8a8193988cf198 Mon Sep 17 00:00:00 2001 From: Drake Costa Date: Mon, 21 Sep 2020 14:35:05 -0700 Subject: [PATCH 1/2] Fix Node Compatibility to be >= v10.17.0 An incorrect setting for the `engines` filed in the project's `package.json` is causing install errors for major versions of node above v10, such as the following: ```bash error fetch-blob@1.0.7: The engine "node" is incompatible with this module. Expected version "^10.17.0" . Got "14.10.0" ``` After running into this error I tried updating both node and yarn to the latest versions (`14.11.0` and `1.22.5` respectively) and continued to get an incompatible module error. It would appear that the or condition isn't being checked, so while `^14.10.0` should satisfy `>=12.3.0`, semver isn't checking against that condition and fast failing on `^10.17.0` instead, limiting the major version range. A simpler condition should satisfy the minimum version requirement, such as `>=10.17.0` as proposed in this PR. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e8e847c..99ea18b 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "node-fetch" ], "engines": { - "node": "^10.17.0 || >=12.3.0" + "node": ">=10.17.0" }, "author": "David Frank", "license": "MIT", From 96ae5c7484b1bca698b6750a6302a4b2a3b578e4 Mon Sep 17 00:00:00 2001 From: Drake Costa Date: Mon, 21 Sep 2020 15:00:06 -0700 Subject: [PATCH 2/2] Try swapping semver values instead. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 99ea18b..56e3f65 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "node-fetch" ], "engines": { - "node": ">=10.17.0" + "node": ">=12.3.0 || ^10.17.0" }, "author": "David Frank", "license": "MIT",