Skip to content

inst: ensure later versions of setuptools are used #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Nov 2, 2017

Fixes #2108 .

Changes proposed in this pull request

  • require later versions of setuptools for installation

Objections with using setuptools 36.6.0?

@codecov-io
Copy link

Codecov Report

Merging #2271 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
- Coverage   72.38%   72.38%   -0.01%     
==========================================
  Files        1188     1188              
  Lines       59186    59186              
  Branches     8506     8506              
==========================================
- Hits        42841    42839       -2     
- Misses      14959    14961       +2     
  Partials     1386     1386
Flag Coverage Δ
#smoketests 72.38% <ø> (-0.01%) ⬇️
#unittests 69.96% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/utils/profiler.py 40.36% <0%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557aad3...1cc3d88. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2271 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
- Coverage   72.38%   72.38%   -0.01%     
==========================================
  Files        1188     1188              
  Lines       59186    59186              
  Branches     8506     8506              
==========================================
- Hits        42841    42839       -2     
- Misses      14959    14961       +2     
  Partials     1386     1386
Flag Coverage Δ
#smoketests 72.38% <ø> (-0.01%) ⬇️
#unittests 69.96% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/utils/profiler.py 40.36% <0%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557aad3...1cc3d88. Read the comment docs.

@satra
Copy link
Member

satra commented Nov 12, 2017

can we add an install test as part of nipype into a controlled environment?

@mgxd
Copy link
Member Author

mgxd commented Nov 13, 2017

@satra I'm not sure what you mean, across various OS? (this PR seems to fix default Ubuntu 16.04)

@satra
Copy link
Member

satra commented Nov 13, 2017

@mgxd - before this fix is implemented can you run a test that breaks before the change is implemented. to basically a test to "test that install works" into an environment.

@mgxd mgxd closed this Nov 13, 2017
@mgxd mgxd deleted the fix/inst branch November 13, 2017 20:09
@mgxd
Copy link
Member Author

mgxd commented Nov 13, 2017

we can actually use earlier versions - see #2280

@mgxd mgxd removed the needs-review label Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants