Remove topological sort for _generate_flatgraph

HippocampusGirl · HippocampusGirl · commit 3fa52a93ed5c · 2021-04-30T09:43:49.000+02:00
- The function is  only adding/removing nodes and adjusting their
  connections
- As such, there are no serial dependencies, and we can iterate in any
  order
diff --git a/nipype/pipeline/engine/workflows.py b/nipype/pipeline/engine/workflows.py
@@ -970,7 +970,7 @@ def _generate_flatgraph(self):
             raise Exception(
                 ("Workflow: %s is not a directed acyclic graph " "(DAG)") % self.name
             )
-        nodes = list(nx.topological_sort(self._graph))
+        nodes = list(self._graph.nodes)
         for node in nodes:
             logger.debug("processing node: %s", node)
             if isinstance(node, Workflow):

Original file line number	Diff line number	Diff line change
`@@ -970,7 +970,7 @@ def _generate_flatgraph(self):`
`970`	`970`	`raise Exception(`
`971`	`971`	`("Workflow: %s is not a directed acyclic graph " "(DAG)") % self.name`
`972`	`972`	`)`
`973`		`- nodes = list(nx.topological_sort(self._graph))`
	`973`	`+ nodes = list(self._graph.nodes)`
`974`	`974`	`for node in nodes:`
`975`	`975`	`logger.debug("processing node: %s", node)`
`976`	`976`	`if isinstance(node, Workflow):`