BF: endian fixes for streamlines code #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
force-pushed
the
endian-fix-streamlines
branch
from
67efe15 to
aae6dee
Compare
Current coverage is 94.23% (diff: 100%)@@ master #473 diff @@
==========================================
Files 160 160
Lines 21197 21198 +1
Methods 0 0
Messages 0 0
Branches 2266 2266
==========================================
+ Hits 19975 19976 +1
Misses 802 802
Partials 420 420
|
Getting errors reading and writing on big-endian machines: http://nipy.bic.berkeley.edu/builders/nibabel-py2.7-ppc/builds/295/steps/shell_5/logs/stdio Closes nipy#471
matthew-brett
force-pushed
the
endian-fix-streamlines
branch
from
aae6dee to
7a6a71e
Compare
|
Oh, right. I've never really been able to test the writing on a big-endian system. Thanks for fixing it. So, the only thing you changed is to force the header to always be written in little-endian (which make sense since we always save the points/scalars/properties in little-endian)? The others changes are simply refactoring the code? If so, this LGTM. |
|
The refactoring is because |
|
Gotcha. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting errors reading and writing on big-endian machines.
Closes #471