Skip to content

[tests] Update tests for msgspec 0.19.0 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2025
Merged

[tests] Update tests for msgspec 0.19.0 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1d18c3
Update tests for msgspec 0.19.0
nhairs Feb 1, 2025
b97a29f
Make this a patch release
nhairs Feb 1, 2025
6827558
Revert "Make this a patch release"
nhairs Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ GitHub = "https://github.com/nhairs/python-json-logger"
dev = [
## Optional but required for dev
"orjson;implementation_name!='pypy'",
"msgspec;implementation_name!='pypy' and python_version<'3.13'",
"msgspec-python313-pre;implementation_name!='pypy' and python_version=='3.13'",
"msgspec;implementation_name!='pypy'",
## Lint
"validate-pyproject[all]",
"black",
Expand Down
10 changes: 8 additions & 2 deletions tests/test_formatters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,14 @@ def test_common_types_encoded(
if pythonjsonlogger.MSGSPEC_AVAILABLE and class_ is MsgspecFormatter:
# Dataclass: https://github.com/jcrist/msgspec/issues/681
# Enum: https://github.com/jcrist/msgspec/issues/680
if obj is SomeDataclass or (
isinstance(obj, enum.Enum) and obj in {MultiEnum.BYTES, MultiEnum.NONE, MultiEnum.BOOL}
# These have been fixed in msgspec 0.19.0, however they also dropped python 3.8 support.
# https://github.com/jcrist/msgspec/releases/tag/0.19.0
if sys.version_info < (3, 9) and (
obj is SomeDataclass
or (
isinstance(obj, enum.Enum)
and obj in {MultiEnum.BYTES, MultiEnum.NONE, MultiEnum.BOOL}
)
):
pytest.xfail()

Expand Down
Loading