Skip to content

Commit f2b6cbe

Browse files
author
Kate Osborn
committed
Standardize on implementation package and add test suite files
1 parent 623f125 commit f2b6cbe

File tree

8 files changed

+22
-9
lines changed

8 files changed

+22
-9
lines changed

internal/implementations/gateway/implementation_suit_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
. "github.com/onsi/gomega"
88
)
99

10-
func TestImplementation(t *testing.T) {
10+
func TestGatewayImplementation(t *testing.T) {
1111
RegisterFailHandler(Fail)
12-
RunSpecs(t, "Implementation Suite")
12+
RunSpecs(t, "Gateway Implementation Suite")
1313
}

internal/implementations/gatewayclass/implementation_suit_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
. "github.com/onsi/gomega"
88
)
99

10-
func TestState(t *testing.T) {
10+
func TestGatewayClassImplementation(t *testing.T) {
1111
RegisterFailHandler(Fail)
12-
RunSpecs(t, "Implementation Suite")
12+
RunSpecs(t, "Gateway Class Implementation Suite")
1313
}

internal/implementations/gatewayconfig/gatewayconfig.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package gatewayconfig
1+
package implementation
22

33
import (
44
"github.com/go-logr/logr"
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package implementation_test
2+
3+
import (
4+
"testing"
5+
6+
. "github.com/onsi/ginkgo/v2"
7+
. "github.com/onsi/gomega"
8+
)
9+
10+
func TestSecretImplementation(t *testing.T) {
11+
RegisterFailHandler(Fail)
12+
RunSpecs(t, "Secret Implementation Suite")
13+
}

internal/implementations/secret/secret.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package secret
1+
package implementation
22

33
import (
44
"github.com/go-logr/logr"

internal/implementations/secret/secret_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package secret_test
1+
package implementation_test
22

33
import (
44
. "github.com/onsi/ginkgo/v2"

internal/implementations/service/service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package service
1+
package implementation
22

33
import (
44
"github.com/go-logr/logr"

internal/manager/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
gw "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/gateway"
1616
gc "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/gatewayclass"
1717
hr "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/httproute"
18-
"github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/secret"
18+
secret "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/secret"
1919
svc "github.com/nginxinc/nginx-kubernetes-gateway/internal/implementations/service"
2020
ngxcfg "github.com/nginxinc/nginx-kubernetes-gateway/internal/nginx/config"
2121
"github.com/nginxinc/nginx-kubernetes-gateway/internal/nginx/file"

0 commit comments

Comments
 (0)