Clarify why not deep copy

pleshakov · pleshakov · commit d1cf0710e485 · 2022-10-14T12:54:20.000-04:00
diff --git a/internal/reconciler/implementation.go b/internal/reconciler/implementation.go
@@ -53,6 +53,8 @@ func newObject(objectType client.Object) client.Object {
 	// without Elem(), t will be a pointer to the type. For example, *v1beta1.Gateway, not v1beta1.Gateway
 	t := reflect.TypeOf(objectType).Elem()
 
+	// We could've used objectType.DeepCopyObject() here, but it's a bit slower confirmed by benchmarks.
+
 	return reflect.New(t).Interface().(client.Object)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ func newObject(objectType client.Object) client.Object {`
`53`	`53`	`// without Elem(), t will be a pointer to the type. For example, *v1beta1.Gateway, not v1beta1.Gateway`
`54`	`54`	`t := reflect.TypeOf(objectType).Elem()`
`55`	`55`
	`56`	`+ // We could've used objectType.DeepCopyObject() here, but it's a bit slower confirmed by benchmarks.`
	`57`	`+`
`56`	`58`	`return reflect.New(t).Interface().(client.Object)`
`57`	`59`	`}`
`58`	`60`