Review feedback

Author: ciarams87

internal/framework/fetch/errors.go

@@ -0,0 +1,23 @@
+package fetch
+
+import "fmt"
+
+// ChecksumMismatchError represents an error when the calculated checksum doesn't match the expected checksum.
+// This type of error should not trigger retries as it indicates data corruption or tampering.
+type ChecksumMismatchError struct {
+	Expected string
+	Actual   string
+}
+
+func (e *ChecksumMismatchError) Error() string {
+	return fmt.Sprintf("checksum mismatch: expected %s, got %s", e.Expected, e.Actual)
+}
+
+// HTTPStatusError represents an HTTP status code error for retry logic.
+type HTTPStatusError struct {
+	StatusCode int
+}
+
+func (e *HTTPStatusError) Error() string {
+	return fmt.Sprintf("unexpected status code: %d", e.StatusCode)
+}

internal/framework/fetch/fetch.go

@@ -33,26 +33,6 @@ const (
 	checksumFileSuffix = ".sha256"
 )
 
-// ChecksumMismatchError represents an error when the calculated checksum doesn't match the expected checksum.
-// This type of error should not trigger retries as it indicates data corruption or tampering.
-type ChecksumMismatchError struct {
-	Expected string
-	Actual   string
-}
-
-func (e *ChecksumMismatchError) Error() string {
-	return fmt.Sprintf("checksum mismatch: expected %s, got %s", e.Expected, e.Actual)
-}
-
-// HTTPStatusError represents an HTTP status code error for retry logic.
-type HTTPStatusError struct {
-	StatusCode int
-}
-
-func (e *HTTPStatusError) Error() string {
-	return fmt.Sprintf("unexpected status code: %d", e.StatusCode)
-}
-
 // RetryBackoffType defines supported backoff strategies.
 type RetryBackoffType string
 
@@ -197,16 +177,7 @@ func (f *DefaultFetcher) GetRemoteFile(targetURL string) ([]byte, error) {
 		return nil, fmt.Errorf("failed to fetch HTTP file after retries: %w", err)
 	}
 
-	if result != nil {
-		return result, nil
-	}
-
-	// This case should ideally not be reached, but as a fallback, return the last known error.
-	if lastErr != nil {
-		return nil, lastErr
-	}
-
-	return nil, fmt.Errorf("failed to fetch HTTP file %s: unknown error", targetURL)
+	return result, nil
 }
 
 // getFileContent fetches content via HTTP(S).

internal/framework/fetch/fetch_test.go

@@ -15,6 +15,8 @@ import (
 )
 
 func TestGetRemoteFile(t *testing.T) {
+	t.Parallel()
+
 	fileContent := "test file content"
 	hasher := sha256.New()
 	hasher.Write([]byte(fileContent))
@@ -226,6 +228,7 @@ func TestGetRemoteFile(t *testing.T) {
 
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
 			g := NewWithT(t)
 
 			var serverURL string
@@ -248,6 +251,7 @@ func TestGetRemoteFile(t *testing.T) {
 }
 
 func TestErrorTypes(t *testing.T) {
+	t.Parallel()
 	tests := []struct {
 		err      error
 		unwraps  error
@@ -274,6 +278,7 @@ func TestErrorTypes(t *testing.T) {
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
 			g := NewWithT(t)
+			t.Parallel()
 			g.Expect(tc.err.Error()).To(Equal(tc.expected))
 
 			if tc.unwraps != nil {