adding general fix for manager

Author: miledxz

internal/mode/static/nginx/runtime/manager.go

@@ -194,12 +194,10 @@ func (m *ManagerImpl) GetUpstreams() (ngxclient.Upstreams, error) {
 }
 
 func NewProcessHandlerImpl(readFile ReadFileFunc, checkFile CheckFileFunc) *ProcessHandlerImpl {
-	ph := &ProcessHandlerImpl{
+	return &ProcessHandlerImpl{
 		readFile:  readFile,
 		checkFile: checkFile,
 	}
-
-	return ph
 }
 
 func (p *ProcessHandlerImpl) FindMainProcess(

internal/mode/static/nginx/runtime/manager_test.go

@@ -237,7 +237,9 @@ func TestFindMainProcess(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			g := NewWithT(t)
-			p := runtime.NewProcessHandlerImpl{}
+			p := runtime.NewProcessHandlerImpl(
+				test.readFile,
+				test.checkFile)
 			result, err := p.FindMainProcess(test.ctx, 2*time.Millisecond)
 
 			if test.expectError {

internal/mode/static/nginx/runtime/runtimefakes/fake_nginx_config_verifier.go

@@ -19,7 +19,7 @@ const configVersionURI = "/var/run/nginx/nginx-config-version.sock"
 var noNewWorkersErrFmt = "reload unsuccessful: no new NGINX worker processes started for config version %d." +
 	" Please check the NGINX container logs for possible configuration issues: %w"
 
-//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . verifyClient
+//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 . nginxConfigVerifier
 
 type nginxConfigVerifier interface {
 	GetConfigVersion() (int, error)