add graceful recovery tests to pipeline

Author: salonichf5

.github/workflows/functional.yml

@@ -119,3 +119,9 @@ jobs:
           ngf_tag=${{ steps.ngf-meta.outputs.version }}
           make test${{ inputs.image == 'plus' && '-with-plus' || ''}} PREFIX=${ngf_prefix} TAG=${ngf_tag} GINKGO_LABEL=telemetry
         working-directory: ./tests
+      - name: Run Gracefule Recovery tests
+        run: |
+          ngf_prefix=ghcr.io/nginxinc/nginx-gateway-fabric
+          ngf_tag=${{ steps.ngf-meta.outputs.version }}
+          make test${{ inputs.image == 'plus' && '-with-plus' || ''}} PREFIX=${ngf_prefix} TAG=${ngf_tag} GINKGO_LABEL=graceful-recovery
+        working-directory: ./tests

tests/graceful-recovery/graceful-recovery.md

@@ -34,7 +34,6 @@ Ensure that NGF can recover gracefully from container failures without any user
 3. Check out the latest tag (unless you are installing the edge version from the main branch).
 4. Go into `deploy/manifests/nginx-gateway.yaml` and change the following:
 
-   - `runAsNonRoot` from `true` to `false`: this allows us to insert our ephemeral container as root which enables us to restart the nginx-gateway container.
    - Add the `--product-telemetry-disable` argument to the nginx-gateway container args.
 
 5. Follow the [installation instructions](https://github.com/nginxinc/nginx-gateway-fabric/blob/main/site/content/installation/installing-ngf/manifests.md)
@@ -130,7 +129,7 @@ to deploy NGINX Gateway Fabric using manifests and expose it through a LoadBalan
 #### Restart Node with draining
 
 1. Switch over to a one-Node Kind cluster. Can run `make create-kind-cluster` from main directory.
-2. Run steps 4-11 of the [Setup](#setup) section above using
+2. Run steps 4-10 of the [Setup](#setup) section above using
 [this guide](https://docs.nginx.com/nginx-gateway-fabric/installation/running-on-kind/) for running on Kind.
 3. Ensure NGF and NGINX container logs are set up and traffic flows through the example application correctly.
 4. Drain the Node of its resources.

tests/suite/graceful_recovery_test.go

@@ -28,7 +28,7 @@ const (
 
 // Since checkContainerLogsForErrors may experience interference from previous tests (as explained in the function
 // documentation), this test is recommended to be run separate from other nfr tests.
-var _ = Describe("Graceful Recovery test", Ordered, Label("nfr", "graceful-recovery"), func() {
+var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"), func() {
 	files := []string{
 		"graceful-recovery/cafe.yaml",
 		"graceful-recovery/cafe-secret.yaml",

tests/suite/system_suite_test.go

@@ -100,7 +100,7 @@ func setup(cfg setupConfig, extraInstallArgs ...string) {
 	Expect(apps.AddToScheme(scheme)).To(Succeed())
 	Expect(apiext.AddToScheme(scheme)).To(Succeed())
 	Expect(coordination.AddToScheme(scheme)).To(Succeed())
-	Expect(v1.AddToScheme(scheme)).To(Succeed())
+	Expect(v1.Install(scheme)).To(Succeed())
 	Expect(batchv1.AddToScheme(scheme)).To(Succeed())
 
 	options := client.Options{