Skip to content

Commit 1754cb1

Browse files
committed
Update docs and comments for Gateway API 0.6.0
1 parent 56f4326 commit 1754cb1

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ The following table lists the software versions NGINX Kubernetes Gateway support
4343

4444
| NGINX Kubernetes Gateway | Gateway API | Kubernetes | NGINX OSS |
4545
|-|-|-|-|
46-
| Edge | 0.5.1 | 1.21+ | 1.21.x *|
46+
| Edge | 0.6.0 | 1.21+ | 1.21.x *|
4747
| 0.2.0 | 0.5.1 | 1.21+ | 1.21.x *|
4848
| 0.1.0 | 0.5.0 | 1.19+ | 1.21.3 |
4949

cmd/gateway/setup.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717
const (
1818
errTmpl = "failed validation - flag: '--%s' reason: '%s'\n"
1919
// nolint:lll
20-
// Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/547122f7f55ac0464685552898c560658fb40073/apis/v1alpha2/shared_types.go#L462
20+
// Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/e9e04e498c566021c9d30ce4dbe0863894c7d7e1/apis/v1beta1/shared_types.go#L494
2121
controllerNameRegex = `^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$` //nolint:lll
2222
)
2323

docs/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ This guide walks you through how to install NGINX Kubernetes Gateway on a generi
2020
1. Install the Gateway CRDs:
2121

2222
```
23-
kubectl apply -k "github.com/kubernetes-sigs/gateway-api/config/crd?ref=v0.5.1"
23+
kubectl apply -k "github.com/kubernetes-sigs/gateway-api/config/crd?ref=v0.6.0"
2424
```
2525

2626
1. Create the nginx-gateway Namespace:

internal/nginx/modules/src/httpmatches.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ function paramsMatch(requestParams, params) {
166166
// (1) if the index is -1, then there are no "=" in the string (e.g. "keyvalue")
167167
// (2) if the index is 0, then there is no value in the string (e.g. "key=").
168168
// NOTE: While query parameter values are permitted to be empty, the Gateway API Spec forces the value to be a non-empty string.
169-
// https://github.com/kubernetes-sigs/gateway-api/blob/50e61865db9659111582080daa5ca1a91bbe265d/apis/v1alpha2/httproute_types.go#L375
169+
// https://github.com/kubernetes-sigs/gateway-api/blob/e9e04e498c566021c9d30ce4dbe0863894c7d7e1/apis/v1beta1/httproute_types.go#L419
170170
// (3) if the index is equal to length -1, then there is no key in the string (e.g. "=value").
171171
if (idx === -1 || (idx === 0) | (idx === p.length - 1)) {
172172
throw Error(`invalid query parameter: ${p}`);

0 commit comments

Comments
 (0)