Skip to content

Conversation

@umaannamalai
Copy link
Contributor

This PR removes unsupported package versions from the tox testing matrix.

@umaannamalai umaannamalai requested a review from a team August 16, 2023 20:54
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 4 0 5.37s
✅ PYTHON black 4 0 0 0.9s
✅ PYTHON flake8 4 0 0.46s
✅ PYTHON isort 4 0 0 0.22s
✅ PYTHON pylint 4 0 4.74s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #904 (dbe53e1) into main (e371b02) will decrease coverage by 0.07%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
- Coverage   81.41%   81.34%   -0.07%     
==========================================
  Files         186      186              
  Lines       18728    18688      -40     
  Branches     3289     3267      -22     
==========================================
- Hits        15247    15202      -45     
- Misses       2539     2547       +8     
+ Partials      942      939       -3     
Files Changed Coverage Δ
newrelic/hooks/logger_loguru.py 87.50% <ø> (+0.13%) ⬆️
newrelic/hooks/messagebroker_pika.py 93.50% <ø> (-1.52%) ⬇️
newrelic/hooks/framework_bottle.py 79.03% <68.75%> (-2.45%) ⬇️
newrelic/hooks/framework_pyramid.py 82.02% <90.90%> (-0.78%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lrafeei
Copy link
Contributor

lrafeei commented Aug 16, 2023

Should we add no-coverage flags in the parts of the code that support instrumentation for unsupported frameworks (in some cases, functions that have been removed/deprecated and no longer used in supported versions)? This way, coverage numbers do not fall, and we do not actually remove existing code

@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 16, 2023
@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 18, 2023
@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Aug 23, 2023
@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Aug 28, 2023
@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Sep 1, 2023
@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Sep 14, 2023
@umaannamalai umaannamalai added this to the v9.1.0 milestone Sep 14, 2023
@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 14, 2023
@TimPansino TimPansino merged commit eff66b5 into main Sep 14, 2023
@TimPansino TimPansino deleted the update-testing-matrix branch September 14, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants